Speed up typeof #85962
Merged
Speed up typeof #85962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saw it in BasicMinimalApi profiles. The ultimate fix is to make `RuntimeType` a frozen object, but this will do for now. Also made a bit of progress in eradicating `EETypePtr` while I'm touching this.
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsSaw it in BasicMinimalApi profiles. The ultimate fix is to make Also made a bit of progress in eradicating Cc @dotnet/ilc-contrib
|
MichalStrehovsky
commented
May 9, 2023
| @@ -103,21 +103,6 @@ public static class Nullable | |||
| { | |||
| ArgumentNullException.ThrowIfNull(nullableType); | |||
|
|
|||
| #if NATIVEAOT | |||
There was a problem hiding this comment.
This is not necessary now that we don't do any reflection blocking.
This was referenced May 9, 2023
SingleAccretion
added a commit
to SingleAccretion/runtimelab
that referenced
this pull request
May 25, 2023
The unhandled exception handling code needs to always reset the scratch block, since it'll put it into a protected region. Some helpers changed signatures in dotnet/runtime#85962.
SingleAccretion
added a commit
to SingleAccretion/runtimelab
that referenced
this pull request
May 25, 2023
The unhandled exception handling code needs to always reset, the scratch block, since it'll put it into a protected region. Some helpers changed signatures in dotnet/runtime#85962.
jkotas
pushed a commit
to dotnet/runtimelab
that referenced
this pull request
May 26, 2023
The unhandled exception handling code needs to always reset the scratch block, since it'll put it into a protected region. Some helpers changed signatures in dotnet/runtime#85962.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw it in BasicMinimalApi profiles. The ultimate fix is to make
RuntimeTypea frozen object, but this will do for now.Also made a bit of progress in eradicating
EETypePtrwhile I'm touching this.Cc @dotnet/ilc-contrib