Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] Fix fingerprinting of relinked dotnet.js during build #86048

Merged
merged 15 commits into from
Jun 2, 2023
Merged

[browser] Fix fingerprinting of relinked dotnet.js during build #86048

merged 15 commits into from
Jun 2, 2023

Conversation

maraf
Copy link
Member

@maraf maraf commented May 10, 2023 •
edited
Loading

  • dotnet.js from runtime pack is replaced by relinked version
  • reading NuGetPackageVersion metadata doesn't produce a value
  • instead we read the version from runtime pack file and than pass it to the task

Depends on #85730
Contributes to dotnet/sdk#30802
Fixes #86959

@maraf maraf added arch-wasm WebAssembly architecture area-Build-mono labels May 10, 2023
@maraf maraf added this to the 8.0.0 milestone May 10, 2023
@maraf maraf self-assigned this May 10, 2023
@ghost
Copy link

ghost commented May 10, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • dotnet.js from runtime pack is replaced by relinked version
  • reading NuGetPackageVersion metadata doesn't produce a value
  • instead we read the version from runtime pack file and than pass it to the task

Depends on #85730
Contributes to dotnet/sdk#30802

Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-Build-mono
Milestone: 8.0.0

This was referenced May 10, 2023
Closed
Closed
@maraf maraf marked this pull request as ready for review May 12, 2023 08:05
@maraf maraf requested review from lewing and radical as code owners May 12, 2023 08:05
@radical
Copy link
Member

radical commented May 12, 2023

Update the blazor tests in WBT to check for this.

@maraf maraf requested a review from pavelsavara May 15, 2023 08:19
@maraf
Copy link
Member Author

maraf commented May 15, 2023

Failures are unrelated

@runfoapp runfoapp bot mentioned this pull request May 15, 2023
Closed
@pavelsavara
Copy link
Member

Ship it! 🚀

@build-analysis build-analysis bot mentioned this pull request May 31, 2023
Open
@radical
Copy link
Member

radical commented May 31, 2023

@maraf will this fix #86959?

@lewing lewing closed this May 31, 2023
@lewing lewing reopened this May 31, 2023
@radical
Copy link
Member

radical commented May 31, 2023

Opened #86959 to fix the failing tests and get CI green again.

@build-analysis build-analysis bot mentioned this pull request May 31, 2023
Closed
@radical radical mentioned this pull request May 31, 2023
Closed
@lewing
Copy link
Member

lewing commented Jun 1, 2023

fixes #86959

@build-analysis build-analysis bot mentioned this pull request Jun 1, 2023
Closed
@radical
Copy link
Member

radical commented Jun 1, 2023

Feedback can be addressed in a follow up PR. This one is important to get CI green.

Also, add a test for fingerprinting turned on, so that code path doesn't regress.

This was referenced Jun 2, 2023
Closed
Closed
@radical
Copy link
Member

radical commented Jun 2, 2023

Failures are known, or unrelated.

@radical radical merged commit 4a2f9d3 into dotnet:main Jun 2, 2023
@maraf maraf mentioned this pull request Jun 2, 2023
Merged
maraf added a commit that referenced this pull request Jun 8, 2023
@maraf
[browser] Fix fingerprinting of relinked dotnet.js - follow up (#87051)
5ebb520 
Address comments from #86048
@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2023
@maraf maraf deleted the WasmSdkFixAotVersionFingerprint branch July 19, 2023 10:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@pavelsavara pavelsavara pavelsavara left review comments

@radical radical radical left review comments

@lewing lewing lewing approved these changes

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[wasm] WBT: Blazor tests failing to find dotnet.native*js
5 participants
@maraf @radical @pavelsavara @lewing @ilonatommy