-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add pre-built detection #86151
Merged
oleksandr-didyk
merged 4 commits into
dotnet:main
from
oleksandr-didyk:add-pre-build-detection
May 18, 2023
Merged
add pre-built detection #86151
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,18 @@ | ||
<!-- See aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them. --> | ||
<UsageData> | ||
<IgnorePatterns> | ||
<UsagePattern IdentityGlob="*/*" /> | ||
<UsagePattern IdentityGlob="Microsoft.SourceBuild.Intermediate.*" /> | ||
|
||
<!-- Allowed and pinned to major version due to https://github.com/dotnet/source-build/issues/3228 --> | ||
<UsagePattern IdentityGlob="Microsoft.NETCore.App.Crossgen2.linux-x64/*8.*" /> | ||
<UsagePattern IdentityGlob="Microsoft.NETCore.App.Runtime.linux-x64/*8.*" /> | ||
<UsagePattern IdentityGlob="*Microsoft.DotNet.ILCompiler/*8.*" /> | ||
|
||
<!-- Will be removed once https://github.com/NuGet/Home/issues/11059 is resolved --> | ||
<UsagePattern IdentityGlob="Nuget.*/*" /> | ||
|
||
<!-- Analyzers cannot be SBRPed + an older release version is being used, meaning there is no intermediate for it | ||
In full source build, this version is overridden by previous repo outputs or come from previously source-built artifacts. --> | ||
<UsagePattern IdentityGlob="Microsoft.CodeAnalysis.Analyzers/*" /> | ||
</IgnorePatterns> | ||
</UsageData> | ||
</UsageData> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmitche I followed your reasoning for baselining
Analyzers
inroslyn
here as well, since it follows the same pattern of product build utilizing latest version while for repo build we cannot use intermediates (for now) or SBRP. Pinging just to verify if you think this train of thought is correct here as well. Thanks!