Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][node] Disable System.Net.Http.Functional with timeouts #86321

Merged
merged 2 commits into from
May 17, 2023
Merged

[wasm][node] Disable System.Net.Http.Functional with timeouts #86321

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1a530c
Active issue.
ilonatommy May 16, 2023
3a3a673
Disable failures uncovered when timeouts are gone.
ilonatommy May 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ where PlatformDetection.IsNotBrowser || !useSsl

[ConditionalTheory]
[MemberData(nameof(SecureAndNonSecure_IPBasedUri_MemberData))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86317", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task GetAsync_SecureAndNonSecureIPBasedUri_CorrectlyFormatted(IPAddress address, bool useSsl)
{
if (LoopbackServerFactory.Version >= HttpVersion20.Value)
Expand Down Expand Up @@ -410,6 +411,7 @@ await LoopbackServer.CreateClientAndServerAsync(async uri =>
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86317", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task PostAsync_ManyDifferentRequestHeaders_SentCorrectly()
{
if (IsWinHttpHandler && UseVersion >= HttpVersion20.Value)
Expand Down Expand Up @@ -1369,6 +1371,7 @@ await server.AcceptConnectionAsync(async connection =>
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86317", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task ReadAsStreamAsync_Cancellation()
{
var tcs = new TaskCompletionSource<bool>();
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Net.Http/tests/FunctionalTests/HttpClientHandlerTest.Url.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ public HttpClientHandlerTest_Url(ITestOutputHelper output) : base(output) { }
[InlineData("/test ", "/test")]
[InlineData("/test%20?a=1", "/test%20?a=1")]
[InlineData("/test ?a=1", "/test%20?a=1")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86317", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task TrimmingTrailingWhiteSpace(string requestPath, string expectedServerPath)
{
string serverPath = null;
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Net.Http/tests/FunctionalTests/HttpContentTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,7 @@ await LoopbackServer.CreateClientAndServerAsync(
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86317", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task ReadAsStringAsync_Unbuffered_CanBeCanceled_AlreadyCanceledCts()
{
await LoopbackServer.CreateClientAndServerAsync(
Expand Down Expand Up @@ -733,6 +734,7 @@ await LoopbackServer.CreateClientAndServerAsync(
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86317", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task ReadAsByteArrayAsync_Unbuffered_CanBeCanceled_AlreadyCanceledCts()
{
await LoopbackServer.CreateClientAndServerAsync(
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Net.Http/tests/FunctionalTests/HttpRequestMessageTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,7 @@ public void ToString_DefaultAndNonDefaultInstance_DumpAllFields()
[InlineData("DELETE")]
[InlineData("OPTIONS")]
[InlineData("HEAD")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/86317", typeof(PlatformDetection), nameof(PlatformDetection.IsNodeJS))]
public async Task HttpRequest_BodylessMethod_NoContentLength(string method)
{
using (HttpClient client = CreateHttpClient())
Expand Down