[WIP] System.Linq.Expressions.Interpreter.CallInstruction.CanCreateArbitraryDelegates should respect IsDynamicCodeSupported

[ivanpovazan]

This PR is marked as draft as its sole purpose is to test potential issues with the change.

The work reflects what @MichalStrehovsky noted regarding adaptations of Linq.Expressions to be AOT compilation friendly: #69410 (comment) and the suggested way of enabling the mentioned codepath proposed by @rolfbjarne

[ghost]

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

Issue Details

---

This PR is marked as draft as its sole purpose is to test potential issues with the change.

The work reflects what @MichalStrehovsky noted regarding adaptations of Linq.Expressions to be AOT compilation friendly: #69410 (comment) and the suggested way of enabling the mentioned codepath proposed by @rolfbjarne

Author:	ivanpovazan
Assignees:	ivanpovazan
Labels:	NO-REVIEW, area-System.Linq.Expressions
Milestone:	-

[ivanpovazan]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ivanpovazan]

Rerun the pipelines once: #86971 gets merged in

[ivanpovazan]

/azp list

[azure-pipelines]

CI/CD Pipelines for this repository:

• runtime-coreclr outerloop
• runtime-coreclr jitstress
• runtime-coreclr jitstressregs
• runtime-coreclr jitstress2-jitstressregs
• runtime-coreclr gcstress0x3-gcstress0xc
• runtime-coreclr gcstress-extra
• runtime-coreclr r2r-extra
• runtime-coreclr jitstress-isas-x86
• runtime-coreclr jitstress-isas-arm
• runtime-coreclr jitstressregs-x86
• runtime-coreclr libraries-jitstressregs
• runtime-coreclr libraries-jitstress2-jitstressregs
• runtime-coreclr r2r
• runtime-coreclr runincontext
• runtime-coreclr crossgen2
• runtime-libraries-coreclr outerloop
• runtime-libraries-coreclr outerloop-windows
• runtime-libraries-coreclr outerloop-linux
• runtime-libraries-coreclr outerloop-osx
• runtime
• runtime-libraries enterprise-linux
• runtime-libraries stress-http
• runtime-libraries stress-ssl
• runtime-dev-innerloop
• runtime-coreclr crossgen2 outerloop
• coreclr-release-outerloop-nightly
• runtime-coreclr crossgen2-composite
• runtime-jit-experimental
• runtime-coreclr libraries-jitstress
• dotnet-linker-tests
• runtime-coreclr ilasm
• runtime-coreclr crossgen2-composite gcstress
• runtime-staging
• runtime-coreclr pgo
• runtime-coreclr libraries-pgo
• Antigen
• runtime-community
• Fuzzlyn
• runtime-coreclr superpmi-replay
• runtime-wasm
• runtime-coreclr superpmi-diffs
• runtime-coreclr superpmi-asmdiffs-checked-release
• runtime-extra-platforms
• jit-cfg
• runtime-wasm-perf
• runtime-llvm
• runtime-coreclr jitstress-random
• runtime-coreclr libraries-jitstress-random
• runtime-android-grpc-client-tests
• runtime-wasm-libtests
• runtime-wasm-non-libtests
• runtime-android
• runtime-androidemulator
• runtime-ioslike
• runtime-ioslikesimulator
• runtime-linuxbionic
• runtime-maccatalyst
• runtime-coreclr pgostress
• runtime-coreclr jitstress-isas-avx512
• runtime-tools-tests
• runtime-libraries-mono outerloop
• runtime-sanitized
• runtime-wasm-dbgtests
• runtime-wasm-optional

[ivanpovazan]

/azp run runtime-extra-platforms

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ivanpovazan]

The failures seem unrelated.

@MichalStrehovsky would it make sense to add a unit test for NativeAOT/MonoAOT which verifies that:
CanCreateArbitraryDelegates=false

Maybe something like:

var linqExprAssembly = typeof(System.Linq.Expressions.Expression).Assembly;
var callInstrType = linqExprAssembly?.GetType("System.Linq.Expressions.Interpreter.CallInstruction");
var canCreateArbitraryDelegatesGetter = callInstrType?.GetMethod("get_CanCreateArbitraryDelegates", BindingFlags.NonPublic | BindingFlags.Static);
Assert.False(canCreateArbitraryDelegatesGetter?.Invoke(null, null));

[MichalStrehovsky]

The failures seem unrelated.

@MichalStrehovsky would it make sense to add a unit test for NativeAOT/MonoAOT which verifies that: CanCreateArbitraryDelegates=false

Maybe something like:

var linqExprAssembly = typeof(System.Linq.Expressions.Expression).Assembly;
var callInstrType = linqExprAssembly?.GetType("System.Linq.Expressions.Interpreter.CallInstruction");
var canCreateArbitraryDelegatesGetter = callInstrType?.GetMethod("get_CanCreateArbitraryDelegates", BindingFlags.NonPublic | BindingFlags.Static);
Assert.False(canCreateArbitraryDelegatesGetter?.Invoke(null, null));

I don't have an opinion. The value of this switch affects runtime throughput and size. We should be able to observe this in size/throughput testing.

[eerhardt]

FYI - note the snags that I hit in this area in #81803 (comment).

[eerhardt]

Closing in favor of #88539.