JIT: Clean up BB successor iteration #86839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove old code * Use visitor with an array as part of AllSuccessorEnumerator
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
assigned 
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue Details
|
jakobbotsch
commented
May 27, 2023
Comment on lines
+1861
to
+1864
| // We store up to 4 successors inline in the enumerator. For ASP.NET | ||
| // and libraries.pmi this is enough in 99.7% of cases. | ||
| BasicBlock* m_successors[4]; | ||
| BasicBlock** m_pSuccessors; |
There was a problem hiding this comment.
Some histograms for count of all-successors:
asp.net:
<= 0 ===> 113751 count ( 15% of total)
1 .. 1 ===> 232465 count ( 48% of total)
2 .. 2 ===> 342117 count ( 96% of total)
3 .. 3 ===> 23292 count ( 99% of total)
4 .. 4 ===> 3215 count ( 99% of total)
5 .. 5 ===> 700 count ( 99% of total)
6 .. 6 ===> 392 count ( 99% of total)
7 .. 7 ===> 165 count ( 99% of total)
8 .. 8 ===> 99 count ( 99% of total)
9 .. 9 ===> 76 count ( 99% of total)
10 .. 10 ===> 152 count (100% of total)
> 10 ===> 299 count (100% of total)libraries.pmi:
<= 0 ===> 291559 count ( 26% of total)
1 .. 1 ===> 321737 count ( 56% of total)
2 .. 2 ===> 438938 count ( 96% of total)
3 .. 3 ===> 27017 count ( 99% of total)
4 .. 4 ===> 4750 count ( 99% of total)
5 .. 5 ===> 1642 count ( 99% of total)
6 .. 6 ===> 522 count ( 99% of total)
7 .. 7 ===> 261 count ( 99% of total)
8 .. 8 ===> 161 count ( 99% of total)
9 .. 9 ===> 130 count ( 99% of total)
10 .. 10 ===> 79 count (100% of total)
> 10 ===> 398 count (100% of total)
|
cc @dotnet/jit-contrib PTAL @AndyAyersMS. Gets rid of the old iterator and changes the enumerator (that's still used for DFS purposes by SSA) to read all the successors into an array. No diffs except for some minor TP improvements. |
AndyAyersMS
approved these changes
Jun 6, 2023
|
Failure is known according to build analysis. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AllSuccessorEnumeratorthat is still used by SSA