-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't enable ILLink analyzers for unsupported TFMs #87071
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned sbomer
Jun 2, 2023
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsReact to changes in dotnet/sdk#32045. Creating as a draft until we are prepared to update to the preview 5 SDK.
|
ViktorHofer
reviewed
Jun 3, 2023
ViktorHofer
reviewed
Jun 3, 2023
ViktorHofer
reviewed
Jun 3, 2023
Co-authored-by: Viktor Hofer <[email protected]>
Co-authored-by: Viktor Hofer <[email protected]>
ViktorHofer
approved these changes
Jun 8, 2023
This was referenced Jun 8, 2023
Closed
ghost
locked as resolved and limited conversation to collaborators
Jul 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React to changes in dotnet/sdk#32045.
Creating as a draft until we are prepared to update to the preview 6 SDK.This contains fixes for dotnet/source-build#3490, to allow building with a preview 6 SDK.This contains fixes for dotnet/source-build#3490, as well as fixes for an unrelated build issue that I'm separating into #87074. @ViktorHofer PTAL, and if this looks good @mthalman plans to apply the changes in source-build.