-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nativeaot][tests] Add smoke unit runtime tests for Native AOT on iOS platforms #87260
Merged
kotlarmilos
merged 124 commits into
dotnet:main
from
kotlarmilos:feature/nativeaot-runtime-tests-ios
Jul 14, 2023
Merged
Changes from 115 commits
Commits
Show all changes
124 commits
Select commit
Hold shift + click to select a range
7b4e749
Initial commit
kotlarmilos 0b18e34
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos a47e8a0
Enable restore projects
kotlarmilos f8bc436
Temorary disable other tests
kotlarmilos 5f8f2d1
Temorary disable other tests
kotlarmilos 40c9979
Fix build command
kotlarmilos 2673823
Fix build command
kotlarmilos 35923f9
Remove NativeAOT runtime flavor
kotlarmilos bdc038f
Fix build command
kotlarmilos ef9d492
Test build configuration
kotlarmilos d7356ac
Test build configuration
kotlarmilos eee4341
Test build configuration
kotlarmilos f4d3d8c
Test build configuration
kotlarmilos 12db78e
Test build configuration
kotlarmilos 20d6ce5
Test build configuration
kotlarmilos a722343
Test build configuration
kotlarmilos 881e58d
Test build configuration
kotlarmilos fb478a1
Test build configuration
kotlarmilos 200fba9
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos 33426b5
Test build configuration
kotlarmilos 5a7fd1c
Test build configuration
kotlarmilos 4f99bc9
Test build configuration
kotlarmilos a733eef
Test build configuration
kotlarmilos 0f94265
Test build configuration
kotlarmilos 4df468c
Test build configuration
kotlarmilos dd96d91
Test build configuration
kotlarmilos 1e8657b
Test build configuration
kotlarmilos a4a1570
Test build configuration
kotlarmilos 7461659
Test build configuration
kotlarmilos 00cb5f1
Test build configuration
kotlarmilos 1707063
Test build configuration
kotlarmilos d601c79
Test build configuration
kotlarmilos a4c7233
Test build configuration
kotlarmilos bf3b44d
Test build configuration
kotlarmilos 833c350
Test build configuration
kotlarmilos 32cb112
Add DevTeamProvisioning parameter
kotlarmilos 3ac0241
Add DevTeamProvisioning parameter
kotlarmilos e2c602c
Add DevTeamProvisioning parameter
kotlarmilos e4a3a65
Test build configuration
kotlarmilos 3b4c6f7
Test host configuration params
kotlarmilos 97a16d5
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos e8ec6b0
Fix buildArgs command
kotlarmilos 8257a75
Disable linker tests
kotlarmilos bd3e2d6
Test host configuration params
kotlarmilos 39a1e1b
Test host configuration params
kotlarmilos 361bf48
Test host configuration params
kotlarmilos df99120
Test host configuration params
kotlarmilos 0ae2d68
Test host configuration params
kotlarmilos 1f00c28
Test host configuration params
kotlarmilos 285d943
Test host configuration params
kotlarmilos 7709ef9
Test host configuration params
kotlarmilos 824a5d6
Test host configuration params
kotlarmilos 463b711
Test host configuration params
kotlarmilos 75bc78d
Prune app bundle
kotlarmilos 6aea2d8
Simplify test launch command for coreclr
kotlarmilos 13f6e58
Update perf pipeline to use Native AOT jobs
kotlarmilos e3276e6
Update perf pipeline to use Native AOT jobs
kotlarmilos 7e75b99
Update perf pipeline to use Native AOT jobs
kotlarmilos 40b0bc3
Update perf pipeline to use Native AOT jobs
kotlarmilos 1ed723f
Merge branch 'dotnet:main' into feature/nativeaot-runtime-tests-ios
kotlarmilos 8187257
Merge branch 'feature/nativeaot-runtime-tests-ios' of github.com:kotl…
kotlarmilos b2ade5a
Build coreclr for the perf runs
kotlarmilos 32cbd8e
Update the sample bundle to match the Mono app dir
kotlarmilos fcb1c25
Skip coreclr build for NativeAOT performance run on iOS
kotlarmilos 9b3438b
Add runtime-ioslike-coreclr and runtime-ioslike-mono azp runs
kotlarmilos a80c416
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos 5dd37a6
Revert disabled tests
kotlarmilos 8b96b80
Revert disabled tests
kotlarmilos 8556872
Revert disabled tests
kotlarmilos 0903a06
Revert disabled tests
kotlarmilos 333bc37
Revert disabled tests
kotlarmilos b265b14
Fix ioslike conditions
kotlarmilos fe4c03f
Use isHostBuild for coreclr runs only
kotlarmilos e8acfd1
Use BuildMonoiOSApp target name
kotlarmilos 840c472
Test Native AOT on iossimulator
kotlarmilos b271f85
Revert main.m template changes
kotlarmilos 1ed6c46
Update LegacyRunnableTestPaths to include tests on apple platforms
kotlarmilos 1bb3807
Update the app template to work on tvos
kotlarmilos 6c80582
Fix tvOS build and add maccatalyst jobs
kotlarmilos 2af7765
Fix maccatalyst build
kotlarmilos e7b92e8
Merge branch 'dotnet:main' into feature/nativeaot-runtime-tests-ios
kotlarmilos 2c62b49
Remove redundant props
kotlarmilos 4e15bd1
Remove redundant props
kotlarmilos 3d3ed5d
Disable failing tests
kotlarmilos a30a8ed
Resolve PR comments
kotlarmilos 0674f40
Add support for stripping debug symbols and enabling IL stripping dur…
kotlarmilos b8a8090
Revert the last commit
kotlarmilos 512df8c
Use the _AppleGenerateAppBundle target from AppleBuild.targets to bui…
kotlarmilos 60da57a
Update IlcToolsPath to use host build
kotlarmilos d14f69a
Update IlcToolsPath to use host build
kotlarmilos 2416dbc
Revert build changes to ensure correct build
kotlarmilos 540e373
Update ExtraAppLinkerArgs
kotlarmilos 8cac3e1
Merge branch 'dotnet:main' into feature/nativeaot-runtime-tests-ios
kotlarmilos 66690f2
Update ILC tools path
kotlarmilos 2d030cd
Use CoreCLRAotSdkDir for IlcSdkPath in the sample app
kotlarmilos 73a1aa0
Enable tests that failed locally due to SIGSEGV
kotlarmilos 34bb1f4
Simplify the build process by using the publish ILC targets
kotlarmilos a5b3aed
Fix lint
kotlarmilos 2f3a232
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos 597ae8c
Build for the target platform
kotlarmilos a134b60
Add TargetArchitecture to the Native AOT host build
kotlarmilos 3cdea35
Generate crosscomponents when target is iOS-like
kotlarmilos 9094a62
Merge branch 'dotnet:main' into feature/nativeaot-runtime-tests-ios
kotlarmilos 397bb17
Revert corsscomponent changes
kotlarmilos ca6b867
Fix CoreCLRILCompilerDir property
kotlarmilos 2ec41ab
Build ILCompiler.Build.Tasks with host bits
kotlarmilos 39d4fb7
Merge branch 'dotnet:main' into feature/nativeaot-runtime-tests-ios
kotlarmilos a264c46
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos 9930333
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos c708237
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos 8f96ddc
Update the CI to use cross-build and add maccatalyst job
kotlarmilos 64ebb2c
Fix build command to pass --cross before -s components
kotlarmilos 3162bdc
Skip check for RuntimeFiles when building Native AOT for apple mobile
kotlarmilos 70aa943
Remove maccatalyst tests
kotlarmilos 96a9127
Update ilc paths in the sample app
kotlarmilos 4320021
Update the sample app to use the cross-build. Disable failing tests w…
kotlarmilos 3559afa
Simplify build process and fix a typo
kotlarmilos be76e86
Test Native AOT perf job
kotlarmilos df3f62b
Update perf build command for Native AOT
kotlarmilos 7b232fb
Test Native AOT perf job
kotlarmilos ac2b9a3
Update IlcToolsPath to use cross-build ilc path
kotlarmilos f5e8fba
Test Native AOT perf job
kotlarmilos 3004990
Use /p:BuildNativeAOTRuntimePack=true to pick up NativeAOT assets ins…
kotlarmilos 06b9868
Merge branch 'dotnet:main' into feature/nativeaot-runtime-tests-ios
kotlarmilos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
parameters: | ||
jobTemplate: '' | ||
hostedOs: '' | ||
hostedArch: '' | ||
osGroup: '' | ||
osSubgroup: '' | ||
archType: '' | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this sounds wrong to me, I think I hit the same issue when adding the runtime packs which is why I added the
BuildNativeAOTRuntimePack
that makes the RuntimeFiles pick up NativeAOT assets instead of CoreCLR on L80.You could set that property too, though I wonder if longer-term we should introduce RuntimeFlavor=NativeAOT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, updated!