Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nativeaot][tests] Add smoke unit runtime tests for Native AOT on iOS platforms #87260

Merged
merged 124 commits into from
Jul 14, 2023
Merged
Show file tree
Hide file tree
Changes from 115 commits
Commits
Show all changes
124 commits
Select commit Hold shift + click to select a range
7b4e749
Initial commit
kotlarmilos Jun 8, 2023
0b18e34
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos Jun 8, 2023
a47e8a0
Enable restore projects
kotlarmilos Jun 8, 2023
f8bc436
Temorary disable other tests
kotlarmilos Jun 8, 2023
5f8f2d1
Temorary disable other tests
kotlarmilos Jun 8, 2023
40c9979
Fix build command
kotlarmilos Jun 8, 2023
2673823
Fix build command
kotlarmilos Jun 8, 2023
35923f9
Remove NativeAOT runtime flavor
kotlarmilos Jun 8, 2023
bdc038f
Fix build command
kotlarmilos Jun 8, 2023
ef9d492
Test build configuration
kotlarmilos Jun 8, 2023
d7356ac
Test build configuration
kotlarmilos Jun 8, 2023
eee4341
Test build configuration
kotlarmilos Jun 8, 2023
f4d3d8c
Test build configuration
kotlarmilos Jun 8, 2023
12db78e
Test build configuration
kotlarmilos Jun 8, 2023
20d6ce5
Test build configuration
kotlarmilos Jun 8, 2023
a722343
Test build configuration
kotlarmilos Jun 8, 2023
881e58d
Test build configuration
kotlarmilos Jun 8, 2023
fb478a1
Test build configuration
kotlarmilos Jun 8, 2023
200fba9
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos Jun 8, 2023
33426b5
Test build configuration
kotlarmilos Jun 8, 2023
5a7fd1c
Test build configuration
kotlarmilos Jun 8, 2023
4f99bc9
Test build configuration
kotlarmilos Jun 8, 2023
a733eef
Test build configuration
kotlarmilos Jun 8, 2023
0f94265
Test build configuration
kotlarmilos Jun 8, 2023
4df468c
Test build configuration
kotlarmilos Jun 8, 2023
dd96d91
Test build configuration
kotlarmilos Jun 8, 2023
1e8657b
Test build configuration
kotlarmilos Jun 8, 2023
a4a1570
Test build configuration
kotlarmilos Jun 8, 2023
7461659
Test build configuration
kotlarmilos Jun 8, 2023
00cb5f1
Test build configuration
kotlarmilos Jun 8, 2023
1707063
Test build configuration
kotlarmilos Jun 8, 2023
d601c79
Test build configuration
kotlarmilos Jun 8, 2023
a4c7233
Test build configuration
kotlarmilos Jun 8, 2023
bf3b44d
Test build configuration
kotlarmilos Jun 8, 2023
833c350
Test build configuration
kotlarmilos Jun 8, 2023
32cb112
Add DevTeamProvisioning parameter
kotlarmilos Jun 8, 2023
3ac0241
Add DevTeamProvisioning parameter
kotlarmilos Jun 9, 2023
e2c602c
Add DevTeamProvisioning parameter
kotlarmilos Jun 9, 2023
e4a3a65
Test build configuration
kotlarmilos Jun 9, 2023
3b4c6f7
Test host configuration params
kotlarmilos Jun 10, 2023
97a16d5
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos Jun 10, 2023
e8ec6b0
Fix buildArgs command
kotlarmilos Jun 10, 2023
8257a75
Disable linker tests
kotlarmilos Jun 10, 2023
bd3e2d6
Test host configuration params
kotlarmilos Jun 10, 2023
39a1e1b
Test host configuration params
kotlarmilos Jun 10, 2023
361bf48
Test host configuration params
kotlarmilos Jun 10, 2023
df99120
Test host configuration params
kotlarmilos Jun 10, 2023
0ae2d68
Test host configuration params
kotlarmilos Jun 10, 2023
1f00c28
Test host configuration params
kotlarmilos Jun 10, 2023
285d943
Test host configuration params
kotlarmilos Jun 10, 2023
7709ef9
Test host configuration params
kotlarmilos Jun 10, 2023
824a5d6
Test host configuration params
kotlarmilos Jun 10, 2023
463b711
Test host configuration params
kotlarmilos Jun 10, 2023
75bc78d
Prune app bundle
kotlarmilos Jun 10, 2023
6aea2d8
Simplify test launch command for coreclr
kotlarmilos Jun 11, 2023
13f6e58
Update perf pipeline to use Native AOT jobs
kotlarmilos Jun 11, 2023
e3276e6
Update perf pipeline to use Native AOT jobs
kotlarmilos Jun 11, 2023
7e75b99
Update perf pipeline to use Native AOT jobs
kotlarmilos Jun 11, 2023
40b0bc3
Update perf pipeline to use Native AOT jobs
kotlarmilos Jun 12, 2023
1ed723f
Merge branch 'dotnet:main' into feature/nativeaot-runtime-tests-ios
kotlarmilos Jun 12, 2023
8187257
Merge branch 'feature/nativeaot-runtime-tests-ios' of github.com:kotl…
kotlarmilos Jun 12, 2023
b2ade5a
Build coreclr for the perf runs
kotlarmilos Jun 12, 2023
32cbd8e
Update the sample bundle to match the Mono app dir
kotlarmilos Jun 12, 2023
fcb1c25
Skip coreclr build for NativeAOT performance run on iOS
kotlarmilos Jun 12, 2023
9b3438b
Add runtime-ioslike-coreclr and runtime-ioslike-mono azp runs
kotlarmilos Jun 13, 2023
a80c416
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos Jun 13, 2023
5dd37a6
Revert disabled tests
kotlarmilos Jun 13, 2023
8b96b80
Revert disabled tests
kotlarmilos Jun 13, 2023
8556872
Revert disabled tests
kotlarmilos Jun 13, 2023
0903a06
Revert disabled tests
kotlarmilos Jun 13, 2023
333bc37
Revert disabled tests
kotlarmilos Jun 13, 2023
b265b14
Fix ioslike conditions
kotlarmilos Jun 13, 2023
fe4c03f
Use isHostBuild for coreclr runs only
kotlarmilos Jun 13, 2023
e8acfd1
Use BuildMonoiOSApp target name
kotlarmilos Jun 13, 2023
840c472
Test Native AOT on iossimulator
kotlarmilos Jun 13, 2023
b271f85
Revert main.m template changes
kotlarmilos Jun 14, 2023
1ed6c46
Update LegacyRunnableTestPaths to include tests on apple platforms
kotlarmilos Jun 14, 2023
1bb3807
Update the app template to work on tvos
kotlarmilos Jun 14, 2023
6c80582
Fix tvOS build and add maccatalyst jobs
kotlarmilos Jun 15, 2023
2af7765
Fix maccatalyst build
kotlarmilos Jun 15, 2023
e7b92e8
Merge branch 'dotnet:main' into feature/nativeaot-runtime-tests-ios
kotlarmilos Jun 15, 2023
2c62b49
Remove redundant props
kotlarmilos Jun 15, 2023
4e15bd1
Remove redundant props
kotlarmilos Jun 15, 2023
3d3ed5d
Disable failing tests
kotlarmilos Jun 16, 2023
a30a8ed
Resolve PR comments
kotlarmilos Jun 16, 2023
0674f40
Add support for stripping debug symbols and enabling IL stripping dur…
kotlarmilos Jun 17, 2023
b8a8090
Revert the last commit
kotlarmilos Jun 17, 2023
512df8c
Use the _AppleGenerateAppBundle target from AppleBuild.targets to bui…
kotlarmilos Jun 17, 2023
60da57a
Update IlcToolsPath to use host build
kotlarmilos Jun 17, 2023
d14f69a
Update IlcToolsPath to use host build
kotlarmilos Jun 17, 2023
2416dbc
Revert build changes to ensure correct build
kotlarmilos Jun 17, 2023
540e373
Update ExtraAppLinkerArgs
kotlarmilos Jun 18, 2023
8cac3e1
Merge branch 'dotnet:main' into feature/nativeaot-runtime-tests-ios
kotlarmilos Jun 18, 2023
66690f2
Update ILC tools path
kotlarmilos Jun 18, 2023
2d030cd
Use CoreCLRAotSdkDir for IlcSdkPath in the sample app
kotlarmilos Jun 19, 2023
73a1aa0
Enable tests that failed locally due to SIGSEGV
kotlarmilos Jun 19, 2023
34bb1f4
Simplify the build process by using the publish ILC targets
kotlarmilos Jun 20, 2023
a5b3aed
Fix lint
kotlarmilos Jun 20, 2023
2f3a232
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos Jun 26, 2023
597ae8c
Build for the target platform
kotlarmilos Jun 26, 2023
a134b60
Add TargetArchitecture to the Native AOT host build
kotlarmilos Jun 26, 2023
3cdea35
Generate crosscomponents when target is iOS-like
kotlarmilos Jun 26, 2023
9094a62
Merge branch 'dotnet:main' into feature/nativeaot-runtime-tests-ios
kotlarmilos Jun 27, 2023
397bb17
Revert corsscomponent changes
kotlarmilos Jun 27, 2023
ca6b867
Fix CoreCLRILCompilerDir property
kotlarmilos Jun 27, 2023
2ec41ab
Build ILCompiler.Build.Tasks with host bits
kotlarmilos Jun 27, 2023
39d4fb7
Merge branch 'dotnet:main' into feature/nativeaot-runtime-tests-ios
kotlarmilos Jun 29, 2023
a264c46
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos Jun 30, 2023
9930333
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos Jul 10, 2023
c708237
Merge branch 'main' into feature/nativeaot-runtime-tests-ios
kotlarmilos Jul 12, 2023
8f96ddc
Update the CI to use cross-build and add maccatalyst job
kotlarmilos Jul 12, 2023
64ebb2c
Fix build command to pass --cross before -s components
kotlarmilos Jul 12, 2023
3162bdc
Skip check for RuntimeFiles when building Native AOT for apple mobile
kotlarmilos Jul 12, 2023
70aa943
Remove maccatalyst tests
kotlarmilos Jul 12, 2023
96a9127
Update ilc paths in the sample app
kotlarmilos Jul 12, 2023
4320021
Update the sample app to use the cross-build. Disable failing tests w…
kotlarmilos Jul 13, 2023
3559afa
Simplify build process and fix a typo
kotlarmilos Jul 13, 2023
be76e86
Test Native AOT perf job
kotlarmilos Jul 13, 2023
df3f62b
Update perf build command for Native AOT
kotlarmilos Jul 13, 2023
7b232fb
Test Native AOT perf job
kotlarmilos Jul 13, 2023
ac2b9a3
Update IlcToolsPath to use cross-build ilc path
kotlarmilos Jul 13, 2023
f5e8fba
Test Native AOT perf job
kotlarmilos Jul 13, 2023
3004990
Use /p:BuildNativeAOTRuntimePack=true to pick up NativeAOT assets ins…
kotlarmilos Jul 14, 2023
06b9868
Merge branch 'dotnet:main' into feature/nativeaot-runtime-tests-ios
kotlarmilos Jul 14, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/liveBuilds.targets
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@
<MonoIncludeFiles Include="$(MonoArtifactsPath)\include\**\*.*" />
</ItemGroup>

<Error Condition="'@(RuntimeFiles)' == ''" Text="The '$(RuntimeFlavor)' subset must be built before building this project." />
<Error Condition="'@(RuntimeFiles)' == '' and !('$(RuntimeFlavor)' == 'CoreCLR' and '$(TargetsAppleMobile)' == 'true')" Text="The '$(RuntimeFlavor)' subset must be built before building this project." />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this sounds wrong to me, I think I hit the same issue when adding the runtime packs which is why I added the BuildNativeAOTRuntimePack that makes the RuntimeFiles pick up NativeAOT assets instead of CoreCLR on L80.

You could set that property too, though I wonder if longer-term we should introduce RuntimeFlavor=NativeAOT

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated!

</Target>

<Target Name="EnsureLocalArtifactsExist">
Expand Down
4 changes: 3 additions & 1 deletion eng/pipelines/common/global-build-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ jobs:

- name: _osParameter
value: -os ${{ parameters.osGroup }}
- name: _archParameter
value: -arch ${{ parameters.archType }}

- ${{ if and(eq(parameters.osGroup, 'linux'), eq(parameters.osSubGroup, '_bionic')) }}:
- name: _osParameter
Expand Down Expand Up @@ -184,7 +186,7 @@ jobs:
- task: CodeQL3000Init@0
displayName: Initialize CodeQL (manually-injected)

- script: $(Build.SourcesDirectory)$(dir)build$(scriptExt) -ci -arch ${{ parameters.archType }} $(_osParameter) $(crossArg) ${{ parameters.buildArgs }} $(_officialBuildParameter) $(_buildDarwinFrameworksParameter) $(_overrideTestScriptWindowsCmdParameter)
- script: $(Build.SourcesDirectory)$(dir)build$(scriptExt) -ci $(_archParameter) $(_osParameter) $(crossArg) ${{ parameters.buildArgs }} $(_officialBuildParameter) $(_buildDarwinFrameworksParameter) $(_overrideTestScriptWindowsCmdParameter)
displayName: Build product
${{ if eq(parameters.useContinueOnErrorDuringBuild, true) }}:
continueOnError: ${{ parameters.shouldContinueOnError }}
Expand Down
40 changes: 32 additions & 8 deletions eng/pipelines/common/platform-matrix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,10 @@ jobs:
platform: maccatalyst_x64
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
jobParameters:
runtimeFlavor: mono
${{ if eq(parameters.runtimeFlavor, '') }}:
runtimeFlavor: mono
${{ else }}:
runtimeFlavor: ${{ parameters.runtimeFlavor }}
buildConfig: ${{ parameters.buildConfig }}
helixQueueGroup: ${{ parameters.helixQueueGroup }}
${{ insert }}: ${{ parameters.jobParameters }}
Expand All @@ -693,7 +696,10 @@ jobs:
platform: maccatalyst_arm64
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
jobParameters:
runtimeFlavor: mono
${{ if eq(parameters.runtimeFlavor, '') }}:
runtimeFlavor: mono
${{ else }}:
runtimeFlavor: ${{ parameters.runtimeFlavor }}
buildConfig: ${{ parameters.buildConfig }}
helixQueueGroup: ${{ parameters.helixQueueGroup }}
${{ insert }}: ${{ parameters.jobParameters }}
Expand All @@ -712,7 +718,10 @@ jobs:
platform: tvos_arm64
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
jobParameters:
runtimeFlavor: mono
${{ if eq(parameters.runtimeFlavor, '') }}:
runtimeFlavor: mono
${{ else }}:
runtimeFlavor: ${{ parameters.runtimeFlavor }}
buildConfig: ${{ parameters.buildConfig }}
helixQueueGroup: ${{ parameters.helixQueueGroup }}
${{ insert }}: ${{ parameters.jobParameters }}
Expand All @@ -731,7 +740,10 @@ jobs:
platform: tvossimulator_x64
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
jobParameters:
runtimeFlavor: mono
${{ if eq(parameters.runtimeFlavor, '') }}:
runtimeFlavor: mono
${{ else }}:
runtimeFlavor: ${{ parameters.runtimeFlavor }}
buildConfig: ${{ parameters.buildConfig }}
helixQueueGroup: ${{ parameters.helixQueueGroup }}
${{ insert }}: ${{ parameters.jobParameters }}
Expand All @@ -750,7 +762,10 @@ jobs:
platform: tvossimulator_arm64
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
jobParameters:
runtimeFlavor: mono
${{ if eq(parameters.runtimeFlavor, '') }}:
runtimeFlavor: mono
${{ else }}:
runtimeFlavor: ${{ parameters.runtimeFlavor }}
buildConfig: ${{ parameters.buildConfig }}
helixQueueGroup: ${{ parameters.helixQueueGroup }}
${{ insert }}: ${{ parameters.jobParameters }}
Expand All @@ -769,7 +784,10 @@ jobs:
platform: ios_arm64
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
jobParameters:
runtimeFlavor: mono
${{ if eq(parameters.runtimeFlavor, '') }}:
runtimeFlavor: mono
${{ else }}:
runtimeFlavor: ${{ parameters.runtimeFlavor }}
buildConfig: ${{ parameters.buildConfig }}
helixQueueGroup: ${{ parameters.helixQueueGroup }}
${{ insert }}: ${{ parameters.jobParameters }}
Expand All @@ -788,7 +806,10 @@ jobs:
platform: iossimulator_x64
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
jobParameters:
runtimeFlavor: mono
${{ if eq(parameters.runtimeFlavor, '') }}:
runtimeFlavor: mono
${{ else }}:
runtimeFlavor: ${{ parameters.runtimeFlavor }}
buildConfig: ${{ parameters.buildConfig }}
helixQueueGroup: ${{ parameters.helixQueueGroup }}
${{ insert }}: ${{ parameters.jobParameters }}
Expand All @@ -807,7 +828,10 @@ jobs:
platform: iossimulator_arm64
shouldContinueOnError: ${{ parameters.shouldContinueOnError }}
jobParameters:
runtimeFlavor: mono
${{ if eq(parameters.runtimeFlavor, '') }}:
runtimeFlavor: mono
${{ else }}:
runtimeFlavor: ${{ parameters.runtimeFlavor }}
buildConfig: ${{ parameters.buildConfig }}
helixQueueGroup: ${{ parameters.helixQueueGroup }}
${{ insert }}: ${{ parameters.jobParameters }}
Expand Down
4 changes: 4 additions & 0 deletions eng/pipelines/common/templates/runtimes/build-test-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,10 @@ jobs:
- name: runtimeFlavorArgs
value: '-mono'

- ${{ if and(eq(parameters.runtimeFlavor, 'coreclr'), in(parameters.osGroup, 'ios', 'iossimulator', 'tvos', 'tvossimulator', 'maccatalyst')) }}:
- name: runtimeFlavorArgs
value: '-nativeaot'

- name: testTreeFilterArg
value: ''

Expand Down
4 changes: 4 additions & 0 deletions eng/pipelines/common/templates/runtimes/test-variables.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@ variables:
- name: runtimeFlavorArgs
value: '-mono'

- ${{ if and(eq(parameters.runtimeFlavor, 'coreclr'), in(parameters.osGroup, 'ios', 'iossimulator', 'tvos', 'tvossimulator', 'maccatalyst')) }}:
- name: runtimeFlavorArgs
value: '-nativeaot'

- name: runtimeVariantArg
value: ''

Expand Down
8 changes: 4 additions & 4 deletions eng/pipelines/common/variables.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ variables:
- name: isWasmOnlyBuild
value: ${{ in(variables['Build.DefinitionName'], 'runtime-wasm', 'runtime-wasm-libtests', 'runtime-wasm-non-libtests', 'runtime-wasm-dbgtests', 'runtime-wasm-optional') }}
- name: isiOSLikeOnlyBuild
value: ${{ in(variables['Build.DefinitionName'], 'runtime-ioslike') }}
value: ${{ in(variables['Build.DefinitionName'], 'runtime-ioslike', 'runtime-ioslike-mono', 'runtime-ioslike-coreclr') }}
- name: isiOSLikeSimulatorOnlyBuild
value: ${{ in(variables['Build.DefinitionName'], 'runtime-ioslikesimulator') }}
- name: isAndroidOnlyBuild
Expand All @@ -32,14 +32,14 @@ variables:
- name: isLinuxBionicOnlyBuild
value: ${{ in(variables['Build.DefinitionName'], 'runtime-linuxbionic') }}
- name: isRunSmokeTestsOnly
value: ${{ notin(variables['Build.DefinitionName'], 'runtime-extra-platforms', 'runtime-wasm', 'runtime-wasm-libtests', 'runtime-wasm-non-libtests', 'runtime-ioslike', 'runtime-ioslikesimulator', 'runtime-android', 'runtime-androidemulator', 'runtime-maccatalyst', 'runtime-linuxbionic') }}
value: ${{ notin(variables['Build.DefinitionName'], 'runtime-extra-platforms', 'runtime-wasm', 'runtime-wasm-libtests', 'runtime-wasm-non-libtests', 'runtime-ioslike', 'runtime-ioslike-mono', 'runtime-ioslike-coreclr', 'runtime-ioslikesimulator', 'runtime-android', 'runtime-androidemulator', 'runtime-maccatalyst', 'runtime-linuxbionic') }}
- name: isNotSpecificPlatformOnlyBuild
value: ${{ notin(variables['Build.DefinitionName'], 'runtime-wasm', 'runtime-wasm-libtests', 'runtime-wasm-non-libtests', 'runtime-ioslike', 'runtime-ioslikesimulator', 'runtime-android', 'runtime-androidemulator', 'runtime-maccatalyst', 'runtime-linuxbionic') }}
value: ${{ notin(variables['Build.DefinitionName'], 'runtime-wasm', 'runtime-wasm-libtests', 'runtime-wasm-non-libtests', 'runtime-ioslike', 'runtime-ioslike-mono', 'runtime-ioslike-coreclr', 'runtime-ioslikesimulator', 'runtime-android', 'runtime-androidemulator', 'runtime-maccatalyst', 'runtime-linuxbionic') }}

# We only run evaluate paths on runtime and runtime-community pipelines on PRs
# keep in sync with /eng/pipelines/common/xplat-setup.yml
- name: dependOnEvaluatePaths
value: ${{ and(eq(variables['Build.Reason'], 'PullRequest'), in(variables['Build.DefinitionName'], 'runtime', 'runtime-community', 'runtime-extra-platforms', 'runtime-wasm', 'runtime-wasm-libtests', 'runtime-wasm-non-libtests', 'runtime-ioslike', 'runtime-ioslikesimulator', 'runtime-android', 'runtime-androidemulator', 'runtime-maccatalyst', 'runtime-linuxbionic', 'dotnet-linker-tests', 'runtime-dev-innerloop', 'runtime-coreclr superpmi-replay', 'runtime-coreclr superpmi-diffs')) }}
value: ${{ and(eq(variables['Build.Reason'], 'PullRequest'), in(variables['Build.DefinitionName'], 'runtime', 'runtime-community', 'runtime-extra-platforms', 'runtime-wasm', 'runtime-wasm-libtests', 'runtime-wasm-non-libtests', 'runtime-ioslike', 'runtime-ioslike-mono', 'runtime-ioslike-coreclr', 'runtime-ioslikesimulator', 'runtime-android', 'runtime-androidemulator', 'runtime-maccatalyst', 'runtime-linuxbionic', 'dotnet-linker-tests', 'runtime-dev-innerloop', 'runtime-coreclr superpmi-replay', 'runtime-coreclr superpmi-diffs')) }}
- name: debugOnPrReleaseOnRolling
${{ if ne(variables['Build.Reason'], 'PullRequest') }}:
value: Release
Expand Down
1 change: 1 addition & 0 deletions eng/pipelines/common/xplat-setup.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
parameters:
jobTemplate: ''
hostedOs: ''
hostedArch: ''
osGroup: ''
osSubgroup: ''
archType: ''
Expand Down
6 changes: 3 additions & 3 deletions eng/pipelines/coreclr/perf-non-wasm-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ jobs:
parameters:
jobTemplate: /eng/pipelines/common/global-build-job.yml
buildConfig: release
runtimeFlavor: mono
runtimeFlavor: coreclr
platforms:
- ios_arm64
jobParameters:
Expand Down Expand Up @@ -223,7 +223,7 @@ jobs:
parameters:
jobTemplate: /eng/pipelines/coreclr/templates/perf-job.yml
buildConfig: release
runtimeFlavor: mono
runtimeFlavor: coreclr
platforms:
- osx_x64
jobParameters:
Expand All @@ -239,7 +239,7 @@ jobs:
parameters:
jobTemplate: /eng/pipelines/coreclr/templates/perf-job.yml
buildConfig: release
runtimeFlavor: mono
runtimeFlavor: coreclr
platforms:
- osx_x64
jobParameters:
Expand Down
4 changes: 2 additions & 2 deletions eng/pipelines/coreclr/templates/build-perf-sample-apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ steps:
artifactName: ${{ parameters.artifactName }}
- template: /eng/pipelines/common/upload-artifact-step.yml
parameters:
rootFolder: $(Build.SourcesDirectory)/src/mono/sample/iOS-NativeAOT/bin/publish/app/HelloiOS/Release-iphoneos/HelloiOS.app
rootFolder: $(Build.SourcesDirectory)/src/mono/sample/iOS-NativeAOT/bin/ios-arm64/Bundle/HelloiOS/Release-iphoneos/HelloiOS.app
includeRootFolder: true
displayName: iOS Sample App Symbols
artifactName: iOSSampleAppSymbols
Expand All @@ -159,7 +159,7 @@ steps:
artifactName: ${{ parameters.artifactName }}
- template: /eng/pipelines/common/upload-artifact-step.yml
parameters:
rootFolder: $(Build.SourcesDirectory)/src/mono/sample/iOS-NativeAOT/bin/publish/app/HelloiOS/Release-iphoneos/HelloiOS.app
rootFolder: $(Build.SourcesDirectory)/src/mono/sample/iOS-NativeAOT/bin/ios-arm64/Bundle/HelloiOS/Release-iphoneos/HelloiOS.app
includeRootFolder: true
displayName: iOS Sample App NoSymbols
artifactName: iOSSampleAppNoSymbols
Expand Down
2 changes: 1 addition & 1 deletion eng/pipelines/coreclr/templates/perf-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ jobs:
# Create Core_Root
- script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) $(buildConfig) $(archType) generatelayoutonly $(librariesOverrideArg) $(_crossBuildPropertyArg)
displayName: Create Core_Root
condition: and(succeeded(), ne(variables.runtimeFlavorName, 'Mono'), ne('${{ parameters.runtimeType }}', 'wasm'))
condition: and(succeeded(), ne(variables.runtimeFlavorName, 'Mono'), ne('${{ parameters.runtimeType }}', 'wasm'), not(in('${{ parameters.runtimeType }}', 'AndroidMono', 'iOSMono', 'iOSNativeAOT')))

# Copy the runtime directory into the testhost folder to include OOBs.
- script: "build.cmd -subset libs.pretest -configuration release -ci -arch $(archType) -testscope innerloop /p:RuntimeArtifactsPath=$(librariesDownloadDir)\\bin\\mono\\$(osGroup).$(archType).$(buildConfigUpper) /p:RuntimeFlavor=mono;xcopy $(Build.SourcesDirectory)\\artifacts\\bin\\runtime\\net8.0-$(osGroup)-$(buildConfigUpper)-$(archType)\\* $(Build.SourcesDirectory)\\artifacts\\bin\\testhost\\net8.0-$(osGroup)-$(buildConfigUpper)-$(archType)\\shared\\Microsoft.NETCore.App\\$(productVersion) /E /I /Y;xcopy $(Build.SourcesDirectory)\\artifacts\\bin\\testhost\\net8.0-$(osGroup)-$(buildConfigUpper)-$(archType)\\* $(Build.SourcesDirectory)\\.dotnet-mono /E /I /Y;copy $(Build.SourcesDirectory)\\artifacts\\bin\\coreclr\\$(osGroup).$(archType).$(buildConfigUpper)\\corerun.exe $(Build.SourcesDirectory)\\.dotnet-mono\\shared\\Microsoft.NETCore.App\\$(productVersion)\\corerun.exe"
Expand Down
Loading