Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-staging] Fix neutral cultures created with the underscore #87417

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jun 12, 2023

Backport of #87411 to release/7.0-staging

/cc @tarekgh

Customer Impact

This is a delta change to the original fix we did in #87152

Testing

Ran regression tests and added more test cases.

Risk

Low as we are not changing any logic other than ensuring compatibility.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Jun 12, 2023

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #87411 to release/6.0-staging

/cc @tarekgh

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: tarekgh
Assignees: -
Labels:

area-System.Globalization

Milestone: -

@tarekgh tarekgh added the Servicing-consider Issue for next servicing release review label Jun 12, 2023
@tarekgh tarekgh added this to the 7.0.x milestone Jun 12, 2023
@carlossanlop
Copy link
Member

carlossanlop commented Jun 12, 2023

@tarekgh @eiriktsarpalis Today is code complete for the July servicing release. If tactics approved, please merge before EOD if you'd like this to be included in the release.

@tarekgh tarekgh added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 12, 2023
@tarekgh
Copy link
Member Author

tarekgh commented Jun 12, 2023

approved offline by email.

@tarekgh tarekgh merged commit c40f850 into dotnet:release/7.0-staging Jun 12, 2023
@tarekgh tarekgh deleted the release/7.0-staging branch June 12, 2023 23:22
@ghost ghost locked as resolved and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants