Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-staging] [mono] permission denied when reading a jitdump file #87427

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jun 12, 2023

Backport of #82520 to release/7.0-staging

/cc @fanyang-mono @saitama951

Customer Impact

With this change, Mono customer could get a perf report with Mono runtime provided jitdump information. Without this change, perf had trouble reading the log files that Mono provided.

Testing

Verified manually locally and passed CI testing.

Risk

None. This is a very minor bug fixing to the Mono jitdump feature, which was designed for performance diagnostics.

@carlossanlop
Copy link
Member

@fanyang-mono @lambdageek @vargaz Today is code complete for the July servicing release. Please get a Tactics approval, sign-off, confirm the CI failures are unrelated, and merge before EOD if you'd like this to be included in the release.

@fanyang-mono
Copy link
Member

CI failures are not related to this PR.

@lambdageek lambdageek added the Servicing-consider Issue for next servicing release review label Jun 13, 2023
@lambdageek lambdageek added this to the 7.0.x milestone Jun 13, 2023
@radical
Copy link
Member

radical commented Jun 14, 2023

/azp run runtime-wasm-libtests

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@radical
Copy link
Member

radical commented Jun 14, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fanyang-mono
Copy link
Member

Tactics has approved this.

@fanyang-mono fanyang-mono added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jun 14, 2023
@fanyang-mono fanyang-mono merged commit 9514ed2 into release/7.0-staging Jun 14, 2023
@jkotas jkotas deleted the backport/pr-82520-to-release/7.0-staging branch June 16, 2023 23:39
@ghost ghost locked as resolved and limited conversation to collaborators Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-VM-meta-mono Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants