[wasm][debugger] Fixing "Frame not in module" after vscode-js-debug changes #87979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @thaystg Issue DetailsFollow up of #87870
|
ilonatommy
approved these changes
Jun 26, 2023
radical
reviewed
Jun 28, 2023
radical
reviewed
Jun 28, 2023
radical
reviewed
Jun 28, 2023
Comment on lines
+584
to
+585
| foreach (ExecutionContext context in contextBag) | ||
| context.Destroyed = true; |
There was a problem hiding this comment.
We'll probably be looking at this stuff more with the mt+debugging, but it's fine for now.
radical
reviewed
Jun 28, 2023
| catch (DebuggerAgentException e) | ||
| { | ||
| //it's not a wasm page then the command throws an error | ||
| if (!e.Message.Contains("getDotnetRuntime is not defined")) |
There was a problem hiding this comment.
Might be useful to add a comment next to getDotnetRuntime saying that when changing the name, instances in debugger should be changed too. And we might have this in more than one place?
radical
approved these changes
Jun 28, 2023
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Jul 3, 2023
thaystg
added a commit
to thaystg/runtime
that referenced
this pull request
Jul 3, 2023
thaystg
added a commit
that referenced
this pull request
Jul 10, 2023
thaystg
added a commit
that referenced
this pull request
Jul 10, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #87870