Do not say the wrong default behavior for blittable arrays in ComInterfaceGenerator warning #88212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsFixes #88205. The warning used to say the default is [In] for blittable arrays, when the default is [In, Out].
|
...es/gen/Microsoft.Interop.SourceGeneration/Marshalling/ByValueContentsMarshalKindValidator.cs
Outdated
Show resolved
Hide resolved
...es/gen/Microsoft.Interop.SourceGeneration/Marshalling/ByValueContentsMarshalKindValidator.cs
Show resolved
Hide resolved
...es/gen/Microsoft.Interop.SourceGeneration/Marshalling/ByValueContentsMarshalKindValidator.cs
Outdated
Show resolved
Hide resolved
...me.InteropServices/gen/Microsoft.Interop.SourceGeneration/Marshalling/GeneratorDiagnostic.cs
Outdated
Show resolved
Hide resolved
...me.InteropServices/gen/Microsoft.Interop.SourceGeneration/Marshalling/GeneratorDiagnostic.cs
Outdated
Show resolved
Hide resolved
...me.InteropServices/gen/Microsoft.Interop.SourceGeneration/Marshalling/GeneratorDiagnostic.cs
Outdated
Show resolved
Hide resolved
...raries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/RcwAroundCcwTests.cs
Outdated
Show resolved
Hide resolved
...s/gen/Microsoft.Interop.SourceGeneration/Marshalling/StaticPinnableManagedValueMarshaller.cs
Outdated
Show resolved
Hide resolved
...icrosoft.Interop.SourceGeneration/Marshalling/UnmanagedToManagedOwnershipTrackingStrategy.cs
Outdated
Show resolved
Hide resolved
...raries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/CompileFails.cs
Outdated
Show resolved
Hide resolved
…erop.SourceGeneration/Marshalling/ByValueContentsMarshalKindValidator.cs Co-authored-by: Jeremy Koritzinsky <[email protected]>
…kip generation of the wrappers if we have any diagnostics.
…use of "unnecessary" diagostics).
...es/gen/Microsoft.Interop.SourceGeneration/Marshalling/ByValueMarshalKindSupportDescriptor.cs
Outdated
Show resolved
Hide resolved
...es/gen/Microsoft.Interop.SourceGeneration/Marshalling/ByValueMarshalKindSupportDescriptor.cs
Outdated
Show resolved
Hide resolved
...es/gen/Microsoft.Interop.SourceGeneration/Marshalling/ByValueMarshalKindSupportDescriptor.cs
Outdated
Show resolved
Hide resolved
...teropServices/gen/ComInterfaceGenerator/Marshallers/ComInterfaceDispatchMarshallerFactory.cs
Outdated
Show resolved
Hide resolved
...es/gen/Microsoft.Interop.SourceGeneration/Marshalling/ByValueMarshalKindSupportDescriptor.cs
Outdated
Show resolved
Hide resolved
...ervices/gen/Microsoft.Interop.SourceGeneration/Marshalling/CustomTypeMarshallingGenerator.cs
Outdated
Show resolved
Hide resolved
...ime.InteropServices/gen/Microsoft.Interop.SourceGeneration/Marshalling/DelegateMarshaller.cs
Outdated
Show resolved
Hide resolved
…erop.SourceGeneration/Marshalling/ByValueMarshalKindSupportDescriptor.cs Co-authored-by: Jeremy Koritzinsky <[email protected]>
…erop.SourceGeneration/Marshalling/CustomTypeMarshallingGenerator.cs Co-authored-by: Jeremy Koritzinsky <[email protected]>
…erop.SourceGeneration/Marshalling/DelegateMarshaller.cs Co-authored-by: Jeremy Koritzinsky <[email protected]>
…enerator/Marshallers/ComInterfaceDispatchMarshallerFactory.cs Co-authored-by: Jeremy Koritzinsky <[email protected]>
…erop.SourceGeneration/Marshalling/ByValueMarshalKindSupportDescriptor.cs Co-authored-by: Jeremy Koritzinsky <[email protected]>
…erop.SourceGeneration/Marshalling/ByValueMarshalKindSupportDescriptor.cs Co-authored-by: Jeremy Koritzinsky <[email protected]>
…erop.SourceGeneration/Marshalling/ByValueContentsMarshalKindValidator.cs Co-authored-by: Jeremy Koritzinsky <[email protected]>
jkoritzinsky
approved these changes
Jul 11, 2023
This was referenced Jul 12, 2023
|
Failures are known |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #88205. The warning used to say the default is [In] for blittable arrays, when the default is [In, Out].
Reworks how Unnecessary / Not supported / supported [In, Out] diagnostic reporting is implemented. Each marshaller will decide which details are provided with the diagnostic and which attributes are unnecessary.
Shares a single Strings.resx with all projects. "Com" or "LibraryImport" suffixes were added to string names that conflicted.