Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for UnsafeAccessor in the trimmer #88268

Merged
merged 53 commits into from
Jul 18, 2023
Merged

Implement support for UnsafeAccessor in the trimmer #88268

merged 53 commits into from
Jul 18, 2023

Commits on Jul 10, 2023

  1. First

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    200b988 View commit details
    Browse the repository at this point in the history

  2. Methods

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    bc3dac0 View commit details
    Browse the repository at this point in the history

  3. Refactoring and true method resolution

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    3983540 View commit details
    Browse the repository at this point in the history

  4. Progress

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    aa8b53a View commit details
    Browse the repository at this point in the history

  5. More tests

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    27d4674 View commit details
    Browse the repository at this point in the history

  6. Tests

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    7725027 View commit details
    Browse the repository at this point in the history

  7. Tests

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    7bede4d View commit details
    Browse the repository at this point in the history

  8. More

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    c83be6f View commit details
    Browse the repository at this point in the history

  9. Fixups after a recent fix in CoreCLR implementation

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    2e62970 View commit details
    Browse the repository at this point in the history

  10. Revert to method group marking 

    Parameter overload resolution is very problematic in Cecil - would have to reimplement it effectively.
    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    b7e1484 View commit details
    Browse the repository at this point in the history

  11. Resolve inhertiance behavior inconsistencies

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    b4fea74 View commit details
    Browse the repository at this point in the history

  12. Simplify the code

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    95f32b2 View commit details
    Browse the repository at this point in the history

  13. Add support for fields

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    8f2f52e View commit details
    Browse the repository at this point in the history

  14. Methods on value types 

    Fixes a bug in CoreCLR and NativeAOT which would allow non-ref this for value instance method accessors. This leads to asserts from JIT.
    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    686528a View commit details
    Browse the repository at this point in the history

  15. Fields on value types

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    6f1ee84 View commit details
    Browse the repository at this point in the history

  16. Requires tests

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    ca883bc View commit details
    Browse the repository at this point in the history

  17. DAM and UnsafeAccessor tests

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    c7aaabc View commit details
    Browse the repository at this point in the history

  18. Formatting

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    93b53a3 View commit details
    Browse the repository at this point in the history

  19. Formatting

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    9fd8178 View commit details
    Browse the repository at this point in the history

  20. Update src/coreclr/tools/Common/TypeSystem/IL/UnsafeAccessors.cs 

    Co-authored-by: Jan Kotas <[email protected]>
    @vitek-karas @jkotas
    vitek-karas and jkotas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    e886374 View commit details
    Browse the repository at this point in the history

  21. Linker tests use both XUnit and VSTest format

    @agocke @vitek-karas
    agocke authored and vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    c623196 View commit details
    Browse the repository at this point in the history

  22. Add enablePublishTestResults

    @agocke @vitek-karas
    agocke authored and vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    0b023e0 View commit details
    Browse the repository at this point in the history

  23. Fix API compat - hide the redefined BCL type

    @vitek-karas
    vitek-karas committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    820f14c View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. Exclude the new tests on mono

    @vitek-karas
    vitek-karas committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    0738762 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. First

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b70becc View commit details
    Browse the repository at this point in the history

  2. Methods

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    cb6f71f View commit details
    Browse the repository at this point in the history

  3. Refactoring and true method resolution

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6638a05 View commit details
    Browse the repository at this point in the history

  4. Progress

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    75974af View commit details
    Browse the repository at this point in the history

  5. More tests

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6722a03 View commit details
    Browse the repository at this point in the history

  6. Tests

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6376210 View commit details
    Browse the repository at this point in the history

  7. Tests

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    6e439de View commit details
    Browse the repository at this point in the history

  8. More

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    a0b2295 View commit details
    Browse the repository at this point in the history

  9. Fixups after a recent fix in CoreCLR implementation

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    43726d7 View commit details
    Browse the repository at this point in the history

  10. Revert to method group marking 

    Parameter overload resolution is very problematic in Cecil - would have to reimplement it effectively.
    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    74a5ee5 View commit details
    Browse the repository at this point in the history

  11. Resolve inhertiance behavior inconsistencies

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    47d82d0 View commit details
    Browse the repository at this point in the history

  12. Simplify the code

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    74d57c0 View commit details
    Browse the repository at this point in the history

  13. Add support for fields

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    4f945d4 View commit details
    Browse the repository at this point in the history

  14. Methods on value types 

    Fixes a bug in CoreCLR and NativeAOT which would allow non-ref this for value instance method accessors. This leads to asserts from JIT.
    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    13972ca View commit details
    Browse the repository at this point in the history

  15. Fields on value types

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    4ffa95d View commit details
    Browse the repository at this point in the history

  16. Requires tests

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    e9fcb68 View commit details
    Browse the repository at this point in the history

  17. DAM and UnsafeAccessor tests

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    ce9376b View commit details
    Browse the repository at this point in the history

  18. Formatting

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    f2c595a View commit details
    Browse the repository at this point in the history

  19. Formatting

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    50a219a View commit details
    Browse the repository at this point in the history

  20. Update src/coreclr/tools/Common/TypeSystem/IL/UnsafeAccessors.cs 

    Co-authored-by: Jan Kotas <[email protected]>
    @vitek-karas @jkotas
    vitek-karas and jkotas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    623a2f0 View commit details
    Browse the repository at this point in the history

  21. Linker tests use both XUnit and VSTest format

    @agocke @vitek-karas
    agocke authored and vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    906ccb9 View commit details
    Browse the repository at this point in the history

  22. Add enablePublishTestResults

    @agocke @vitek-karas
    agocke authored and vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    7dbca19 View commit details
    Browse the repository at this point in the history

  23. Fix API compat - hide the redefined BCL type

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    45cd27a View commit details
    Browse the repository at this point in the history

  24. Exclude the new tests on mono

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    58741fb View commit details
    Browse the repository at this point in the history

  25. Merge branch 'main' into TrimmerUnsafeAccessor

    @lambdageek
    lambdageek authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    344037f View commit details
    Browse the repository at this point in the history

  26. [mono] uncomment passing tests

    @lambdageek
    lambdageek committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    ec66190 View commit details
    Browse the repository at this point in the history

  27. Merge branch 'TrimmerUnsafeAccessor' of https://github.com/vitek-kara… 

    …s/runtime into TrimmerUnsafeAccessor
    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    22023ed View commit details
    Browse the repository at this point in the history

  28. Fixes after merge with main

    @vitek-karas
    vitek-karas committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    9d5e30f View commit details
    Browse the repository at this point in the history

  29. Update src/tools/illink/src/linker/Linker.Steps/UnsafeAccessorMarker.cs 

    Co-authored-by: Sven Boemer <[email protected]>
    @vitek-karas @sbomer
    vitek-karas and sbomer authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    b238760 View commit details
    Browse the repository at this point in the history