Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't generate Unmanaged-to-Managed stubs with diagnostics #88679

Merged
merged 5 commits into from
Jul 13, 2023
Merged

Don't generate Unmanaged-to-Managed stubs with diagnostics #88679

merged 5 commits into from
Jul 13, 2023

Commits on Jul 11, 2023

  1. Don't generate invalid UnmanagedCallersOnly wrappers. Instead, just s… 

    …kip generation of the wrappers if we have any diagnostics.
    @jkoritzinsky
    jkoritzinsky committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    c48213e View commit details
    Browse the repository at this point in the history

  2. Only filter on the unmanaged to managed stub diagnostics.

    @jkoritzinsky
    jkoritzinsky committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    d324406 View commit details
    Browse the repository at this point in the history

  3. Only skip on error diagnostics (we don't want to skip generation beca… 

    …use of "unnecessary" diagostics).
    @jkoritzinsky
    jkoritzinsky committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    d3f00a8 View commit details
    Browse the repository at this point in the history

  4. Invert condition

    @jkoritzinsky
    jkoritzinsky committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    1dd935f View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Use the correct collection for the methods

    @jkoritzinsky
    jkoritzinsky committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    c5096bd View commit details
    Browse the repository at this point in the history