Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash the trim analyzer if it finds unrecognized nodes in the input #88836

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Don't crash the trim analyzer if it finds unrecognized nodes in the input #88836

merged 1 commit into from
Jul 17, 2023

Commits on Jul 13, 2023

  1. Don't crash the trim analyzer if it finds unrecognized nodes in the i… 

    …nput

New versions of the compiler will introduce new nodes and values. The analyzer can never be 100% in sycn with the compiler, so it needs to be able to gracefully handle nodes it doesn't know anything about.

Change the several throws to just Debug.Fail. For end-users if we hit unrecognized node, we will effectively ignore that part of the code. So not 100% precise, but the analyzer will never be 100% regardles.

This is in response to dotnet#88684, but we can't add tests for it yet because the necessary compiler changes are in Preview 6, the repo is still on Preview 5.
    @vitek-karas
    vitek-karas committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    0a3cded View commit details
    Browse the repository at this point in the history