Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Re-enable JSON tests #88883

Merged
merged 1 commit into from
Jul 14, 2023
Merged

[wasm] Re-enable JSON tests #88883

merged 1 commit into from
Jul 14, 2023

Conversation

kg
Copy link
Member

@kg kg commented Jul 14, 2023

Should be fine to do this since #88876 was merged.

@kg kg requested a review from radical July 14, 2023 02:17
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 14, 2023
@ghost ghost assigned kg Jul 14, 2023
@radical
Copy link
Member

radical commented Jul 14, 2023

/azp run runtime-wasm-libtests

@azure-pipelines
Copy link

No commit pushedDate could be found for PR 88883 in repo dotnet/runtime

@radical
Copy link
Member

radical commented Jul 14, 2023

This error with running the pipeline has been hit on a few PRs since last week, and is being looked AFAIK!

Don't merge this without running that pipeline though because STJ/aot will be run only in that on a PR.

@radical
Copy link
Member

radical commented Jul 14, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost
Copy link

ghost commented Jul 14, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Should be fine to do this since #88876 was merged.

Author: kg
Assignees: kg
Labels:

arch-wasm, area-Codegen-AOT-mono, needs-area-label

Milestone: -

@radical radical removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 14, 2023
@radical radical added this to the 8.0.0 milestone Jul 14, 2023
@radical
Copy link
Member

radical commented Jul 14, 2023

Tests passed!

@radical
Copy link
Member

radical commented Jul 14, 2023

None of the other runs are related to this at all.

@radical radical merged commit df00775 into dotnet:main Jul 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants