Light up core ASCII.CaseConversion methods with Vector256/Vector512 code paths #88923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated the naming and bug fixes.
path to improve the performance in VectorContainsNonAsciiChar
Add optimization for ChangeWidthAndWriteTo when Vector512 is available
Add 32-byte and 64-byte inputs to test on Vectorized path.
StoreLowerUnsafe, and use GetLower() instead.
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-text-encoding Issue DetailsDescriptionThis PR lights up some code path in ASCII.CaseConversion with Vector256/Vector512 code, namely, ChangeCases<TFrom, TTo, TCasting>, which is the base method for all the case conversion APIs, including We are open to adjusting the implementation style for either path. Perf numbers coming soon. Perfperf number coming soon
|
EgorBo
reviewed
Jul 16, 2023
src/libraries/System.Private.CoreLib/src/System/Text/Ascii.Utility.cs
Outdated
Show resolved
Hide resolved
ghost
closed this
|
Draft Pull Request was automatically closed for 30 days of inactivity. Please let us know if you'd like to reopen it. |
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR lights up some code path in ASCII.CaseConversion with Vector256/Vector512 code, namely, ChangeCases<TFrom, TTo, TCasting>, which is the base method for all the case conversion APIs, including
ToUpper(InPlace),ToLower(InPlace).We are open to adjusting the implementation style for either path. Perf numbers coming soon.
Perf
perf number coming soon