Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WASM] Add ILStrip task to wasm app build process #88926

Merged
merged 21 commits into from
Aug 10, 2023
Merged

[WASM] Add ILStrip task to wasm app build process #88926

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
3f632d1
Add ILStrip task to wasm app build process
fanyang-mono Jul 14, 2023
2f1765b
Make it work for wasm app building workflow
fanyang-mono Jul 16, 2023
cfd4c60
Interp: stop inlining stripped methods. ILStrip: set code size to zer…
fanyang-mono Jul 17, 2023
074abf0
[mono][aot] Avoid adding some methods to the compiled method file.
vargaz Jul 17, 2023
ae0c62a
Only trim the methods that interpreter is able to call the aot'ed ver…
fanyang-mono Jul 27, 2023
52a2a8c
Add default value and documentation for WASMStripIL
fanyang-mono Jul 27, 2023
0c9a83e
Move jit_call_can_be_supported to interp.c
fanyang-mono Aug 2, 2023
7d583ce
Minor format fix
fanyang-mono Aug 2, 2023
f7bb601
Add a test
fanyang-mono Aug 2, 2023
41cf1b7
For testing
fanyang-mono Aug 2, 2023
617d8a7
Fix typo
fanyang-mono Aug 3, 2023
feead71
Skip TestUtilities Reference
fanyang-mono Aug 3, 2023
74fbf16
Address review feedback
fanyang-mono Aug 7, 2023
c2eb9e2
Merge branch 'main' into enable_il_trim_wasm
fanyang-mono Aug 7, 2023
64bbd78
Change it to true
fanyang-mono Aug 8, 2023
859f10a
Change name to trimming eligible
fanyang-mono Aug 9, 2023
4d5203b
Merge branch 'main' into enable_il_trim_wasm
fanyang-mono Aug 9, 2023
eaf4f55
Remove testing
fanyang-mono Aug 9, 2023
0ac748c
Address review feedback
fanyang-mono Aug 9, 2023
5476bb1
Address review feedback from Kate
fanyang-mono Aug 9, 2023
99b91be
Add a var for llvm_only
fanyang-mono Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/mono/wasm/build/WasmApp.InTree.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<Project>
<!-- This depends on the root Directory.Build.targets imported this file -->
<UsingTask TaskName="MonoAOTCompiler" AssemblyFile="$(MonoAOTCompilerTasksAssemblyPath)" />
<UsingTask TaskName="ILStrip" AssemblyFile="$(MonoTargetsTasksAssemblyPath)" />
fanyang-mono marked this conversation as resolved.
Show resolved Hide resolved
fanyang-mono marked this conversation as resolved.
Show resolved Hide resolved
<UsingTask TaskName="RuntimeConfigParserTask" AssemblyFile="$(MonoTargetsTasksAssemblyPath)" />

<!-- TODO: this breaks runtime tests on Helix due to the file not being there for some reason. Once this is fixed we can remove the UpdateRuntimePack target here -->
Expand Down
13 changes: 13 additions & 0 deletions src/mono/wasm/build/WasmApp.Native.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,12 +674,25 @@
CacheFilePath="$(_AOTCompilerCacheFile)"
LLVMDebug="dwarfdebug"
LLVMPath="$(EmscriptenUpstreamBinPath)"
CollectCompiledMethods="$(WASMStripIL)"
fanyang-mono marked this conversation as resolved.
Show resolved Hide resolved
CompiledMethodsOutputDirectory="$(_WasmIntermediateOutputPath)tokens"
IntermediateOutputPath="$(_WasmIntermediateOutputPath)"
AotProfilePath="@(AotProfilePath)">

<Output TaskParameter="CompiledAssemblies" ItemName="_WasmAssembliesInternal" />
<Output TaskParameter="FileWrites" ItemName="FileWrites" />
</MonoAOTCompiler>
<ILStrip
Condition=" '$(WASMStripIL)' == 'true' "
TrimIndividualMethods="true"
fanyang-mono marked this conversation as resolved.
Show resolved Hide resolved
Assemblies="@(_WasmAssembliesInternal)">
<Output TaskParameter="TrimmedAssemblies" ItemName="_ILStripTrimmedAssemblies" />
</ILStrip>
<Move
Condition=" '$(WASMStripIL)' == 'true' "
SourceFiles="@(_ILStripTrimmedAssemblies->'%(TrimmedAssemblyFileName)')"
DestinationFiles="@(_ILStripTrimmedAssemblies)"
/>

<ItemGroup>
<_BitcodeFile Include="%(_WasmAssembliesInternal.LlvmBitcodeFile)" />
Expand Down