Remove the ignore from CustomStepCanResolveTypesAfterSweep
#89016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ignore is pointless. `#if` cannot be used to ignore a test. Tests are collected from whatever version of `Mono.Linker.Tests.Cases` is handy. It could be a net7 build. It could be net471.
dotnet-issue-labeler
bot
added
the
needs-area-label
ghost
added
linkable-framework
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr, @marek-safar Issue DetailsThere are a few reasons to remove this.
|
vitek-karas
approved these changes
Jul 17, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few reasons to remove this.
#ifcannot be used to ignore a test. Tests are collected from whatever version ofMono.Linker.Tests.Casesis handy. It could be a net7 build. It could be net471. Our NUnit tests run on net7 and so we collect which tests to run from a net7 build ofMono.Linker.Tests.Cases. This means we collect and run this test.Extensibilityfolder do this and I don't see anything special about this one.