Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TestOnly] port test fixes #89063

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[TestOnly] port test fixes #89063

merged 1 commit into from
Jul 18, 2023

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jul 18, 2023

Fixes #86338

Port #88969

@ghost ghost assigned tarekgh Jul 18, 2023
@ghost
Copy link

ghost commented Jul 18, 2023

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #86338

Port #88969

Author: tarekgh
Assignees: tarekgh
Labels:

area-System.Globalization
Milestone: -

@tarekgh tarekgh added the Servicing-approved Approved for servicing release label Jul 18, 2023
@tarekgh
Copy link
Member Author

tarekgh commented Jul 18, 2023

@eiriktsarpalis this is straight backport from the PR you have reviewed before. Please have a quick look. Thanks!

CC @carlossanlop

carlossanlop
carlossanlop approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test only change. If the CI looks good, feel free to merge.

@tarekgh tarekgh merged commit 1e34325 into dotnet:release/6.0-staging Jul 18, 2023
@tarekgh tarekgh deleted the release/6.0-staging branch July 18, 2023 14:52
@tarekgh tarekgh mentioned this pull request Jul 18, 2023
Closed
@carlossanlop carlossanlop mentioned this pull request Jul 18, 2023
Open
@carlossanlop
Copy link
Member

I opened #89084 to track the unrelated failure.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eiriktsarpalis eiriktsarpalis eiriktsarpalis approved these changes

@carlossanlop carlossanlop carlossanlop approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.Globalization Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tarekgh @carlossanlop @eiriktsarpalis