Disable reflection in source gen tests and fix AOT testing. #89105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsFix #88982.
|
tarekgh
approved these changes
Jul 18, 2023
eerhardt
approved these changes
Jul 18, 2023
| @@ -236,6 +236,11 @@ public async Task IgnoreCycles_OnExtensionData() | |||
| [Fact] | |||
| public async Task IgnoreCycles_DoesNotSupportPreserveSemantics() | |||
| { | |||
| if (StreamingSerializer is null) | |||
There was a problem hiding this comment.
Is there a condition on the Fact we could do instead? That would describe the platforms/configuration this test isn't supported in.
There was a problem hiding this comment.
I'm not sure, it's an abstract test suite and StreamingSerializer is overridden by derived classes. I don't think it could be done with the existing ConditionalFact/ConditionalTheory infrastructure without substantial refactoring of the test suites.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #88982.