Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build less of libs for CoreCLR tools tests #89154

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

MichalStrehovsky
Copy link
Member

Similar to #89153. I don't think we need System.Speech & co for tools tests.

Cc @dotnet/ilc-contrib @dotnet/illink-contrib @dotnet/illink @dotnet/crossgen-contrib

Similar to #89153. I don't think we need System.Speech & co for tools tests.
@ghost
Copy link

ghost commented Jul 19, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Similar to #89153. I don't think we need System.Speech & co for tools tests.

Cc @dotnet/ilc-contrib @dotnet/illink-contrib @dotnet/illink @dotnet/crossgen-contrib

Author: MichalStrehovsky
Assignees: MichalStrehovsky
Labels:

area-Infrastructure-coreclr

Milestone: -

@MichalStrehovsky
Copy link
Member Author

Looks like the relevant leg succeeded and finished 2 minutes faster than some random other PR I opened (not that the CI times are very reliably measurable).

Copy link
Member

@vitek-karas vitek-karas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@hoyosjs
Copy link
Member

hoyosjs commented Jul 19, 2023

Issue is #89146 and #89094

@hoyosjs hoyosjs merged commit ef4860a into main Jul 19, 2023
151 of 162 checks passed
@jkotas jkotas deleted the MichalStrehovsky-patch-3 branch July 19, 2023 21:40
@ghost ghost locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants