-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Unsafe.IsAddressLess/GreaterThanOrEqualTo methods #89156
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
The mono changes look ok. |
JIT looks ok too, but VM seems to be missing changes in jitinterface.cpp e.g. runtime/src/coreclr/vm/jitinterface.cpp Lines 6972 to 6986 in c430570
Presumably, we don't have to implement them in R2R/CoreCLR with raw il code and leave only JIT version if we make them "must expand"/recursive? (but it's not related to your PR - we can do that sort of clean up separately if it's possible) |
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices Issue DetailsFixes #88478
|
#define OP_PCGT_UN OP_LCGT_UN | ||
#define OP_PCGE_UN OP_LCGE_UN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vargaz, it looks like while OP_ICLE_UN and OP_ICGE_UN exist, OP_LCLE_UN and OP_LCGE_UN don't. What would you recommend as the right way to implement this? Remove these defines and update intrinsics.c with an implementation that emits e.g. a cgt and ceq for less than or equal?
Fixes #88478