Try to improve EventSource_ParallelRequests_LogsNewConnectionIdForEachRequest reliability #89192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hRequest reliability
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #89035. We can reopen it if it continues to fail
Working on a guess here, if the server tasks are unblocked too soon, they might quickly process the request, and the client will assign another request to that connection. As a result, some server connections may never receive a request, which causes the test to time out.
The main change is unblocking the server tasks after we've read all client requests.
Then I also changed the
WhenAlls toWhenAllCompletedOrAnyFailedto see if we can get better error information.Edit: While that race might have happened, after switching to
WhenAllCompletedOrAnyFailedthe logs show that the server was rejecting connections. Not seeing failures anymore after raising theListenBacklog.