Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nodejs][http] remove active issue 86326 #89588

Merged
merged 2 commits into from
Jul 29, 2023
Merged

[nodejs][http] remove active issue 86326 #89588

merged 2 commits into from
Jul 29, 2023

Conversation

pavelsavara
Copy link
Member

Fixes #86326
Real fix it #89393

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Net.Http labels Jul 27, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Jul 27, 2023
@pavelsavara pavelsavara self-assigned this Jul 27, 2023
@ghost
Copy link

ghost commented Jul 27, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #86326
Real fix it #89393

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Net.Http
Milestone: 8.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 27, 2023
Closed
Open
Closed
Closed
Open
@pavelsavara pavelsavara marked this pull request as ready for review July 28, 2023 05:56
@pavelsavara pavelsavara added the os-browser Browser variant of arch-wasm label Jul 28, 2023
@radical
Copy link
Member

radical commented Jul 28, 2023

Did you mean "remove active issue"?
Also, [10:54:23] info: STARTRESULTXML 119245 77u/PD94bWwgdmVyc2, looks like we are having the nodejs issue with getting the full log string.

@pavelsavara pavelsavara changed the title [nodejs][http] enable active issue 86326 [nodejs][http] remove active issue 86326 Jul 28, 2023
@pavelsavara
Copy link
Member Author

Did you mean "remove active issue"?

Yes, thanks

Also, [10:54:23] info: STARTRESULTXML 119245 77u/PD94bWwgdmVyc2, looks like we are having the nodejs issue with getting the full log string.

I think the real trouble is [10:54:23] info: MONO_WASM: Assert failed: mono runtime already exited with 0 and I already have #89425 for that.

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Jul 29, 2023
Open
3 tasks
@pavelsavara pavelsavara merged commit 6f9792f into dotnet:main Jul 29, 2023
116 of 122 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2023
@pavelsavara pavelsavara deleted the browser_nodejs_http_enable_86326 branch September 2, 2024 15:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ilonatommy ilonatommy ilonatommy approved these changes

@radical radical radical approved these changes

@maraf maraf Awaiting requested review from maraf

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Net.Http os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

[wasm][node] Test failures on System.Net.Http.Functional
3 participants
@pavelsavara @radical @ilonatommy