-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the RequiresLocationAttribute #89870
Conversation
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices Issue DetailsThis resolves #85910. It is necessary to avoid potential downstream issues with the use of the attribute as a
|
Marked as draft while this waits for final confirmation from @jaredpar, @jjonescz, @stephentoub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: could you add a single test to https://github.com/dotnet/runtime/blob/main/src/libraries/System.Runtime/tests/System/Runtime/CompilerServices/AttributesTests.cs ?
I do not forsee any changes. There is a C# LDM meeting on |
Btw, the attribute isn't used as modreq in virtual methods, the existing InAttribute is used there. RequiresLocationAttribute is used only as modopt in function pointers. |
This resolves #85910. It is necessary to avoid potential downstream issues with the use of the attribute as a
modreq
invirtual members
andfunction pointers
.