Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] fix order of libraryInitializers execution #90189

Merged
merged 2 commits into from
Aug 9, 2023
Merged

[browser] fix order of libraryInitializers execution #90189

merged 2 commits into from
Aug 9, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Aug 8, 2023 •
edited
Loading

To fix Microsoft.AspNetCore.Components.E2ETest.Tests.JsInitializersTest.InitializersWork Blazor E2E test
Build

Blazor expects that scripts are already loaded when we call onConfigLoaded event.

@pavelsavara pavelsavara added this to the 8.0.0 milestone Aug 8, 2023
@pavelsavara pavelsavara self-assigned this Aug 8, 2023
@ghost
Copy link

ghost commented Aug 8, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

To fix Microsoft.AspNetCore.Components.E2ETest.Tests.JsInitializersTest.InitializersWork Blazor E2E test

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 8.0.0

@pavelsavara pavelsavara mentioned this pull request Aug 8, 2023
Merged
radical
radical approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on request, no review.

@radical
Copy link
Member

radical commented Aug 8, 2023

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Aug 9, 2023
Closed
@radical radical merged commit 18b668a into dotnet:main Aug 9, 2023
42 of 45 checks passed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 8, 2023
@pavelsavara pavelsavara deleted the browser_fix_initializers branch September 2, 2024 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@kg kg Awaiting requested review from kg

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @radical