Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoongArch64] Fix the error register in JIT_WriteBarrier. #90568

Merged
merged 1 commit into from
Aug 16, 2023
Merged

[LoongArch64] Fix the error register in JIT_WriteBarrier. #90568

merged 1 commit into from
Aug 16, 2023

Conversation

LuckyXu-HF
Copy link
Contributor

@LuckyXu-HF LuckyXu-HF commented Aug 15, 2023 •
edited
Loading

This PR is part of the issue #69705 to amend the LA's port.

Fix the error register in JIT_WriteBarrier for LoongArch64.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 15, 2023
@LuckyXu-HF
Copy link
Contributor Author

cc @shushanhf ,Could you please review this PR?
Thanks

@build-analysis build-analysis bot mentioned this pull request Aug 15, 2023
Closed
shushanhf
shushanhf approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@shushanhf shushanhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~
Thanks

@build-analysis build-analysis bot mentioned this pull request Aug 15, 2023
Closed
@LuckyXu-HF
Copy link
Contributor Author

Hi, @jkotas , Could you please review this PR?
Thanks

jkotas
jkotas approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jkotas jkotas merged commit 55a9a02 into dotnet:main Aug 16, 2023
104 of 107 checks passed
@LuckyXu-HF LuckyXu-HF deleted the main-LA64 branch September 4, 2023 07:25
@ghost ghost locked as resolved and limited conversation to collaborators Oct 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkotas jkotas jkotas approved these changes

@shushanhf shushanhf shushanhf approved these changes

Assignees
No one assigned
Labels
arch-loongarch64 area-VM-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LuckyXu-HF @jkotas @shushanhf