[release/8.0-rc1] [workloads] Put quotes around GetFileName call when collecting telemetry #90606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There are cases where `%(ReferencePath)` is empty, so prevent exceptions by quoting the value. Fixes #90584
dotnet-issue-labeler
bot
added
the
needs-area-label
|
@steveisok is this ready to discuss in Tactics? Asking so you add |
lewing
approved these changes
Aug 15, 2023
src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest/WorkloadTelemetry.targets
Outdated
Show resolved
Hide resolved
steveisok
added
Servicing-approved
|
Let me know when the CI finishes so I can merge. Just don't click on "Update branch", because the CI restarts. |
All good |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #90588 to release/8.0-rc1
/cc @steveisok
Customer Impact
Found in Xamarin iOS testing, there can be runs where ReferencePath is empty which would make an msbuild condition fail because it calls GetFileName without any value.
The fix is to add quotes around the item preventing the error.
Testing
Validated locally against sample iOS projects
Risk
Low
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.