[release/8.0] Switch fx_ver_t::as_str from stringstream to append/to_string #90760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsBackport of #90652 to release/8.0 /cc @elinor-fung Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
jeffschwMSFT
approved these changes
Aug 17, 2023
vitek-karas
approved these changes
Aug 17, 2023
|
@elinor-fung @vitek-karas - Are the CI failures related to this change? I have not seen them before. |
|
They are not related. This change does not affect native AOT at all. |
|
Ok thanks for confirming. I opened an issue to track this: #90775 Merging now. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #90652 to release/8.0
/cc @elinor-fung
Customer Impact
There is no functional change here. This updates a function used by host binaries in a way that reduces the size of the resulting binaries.
Testing
Automated tests around version resolution.
Risk
Low.