Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-rc1] [WASM] Enable telemetry for WasmStripILAfterAOT #90827

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 18, 2023

Backport of #90820 to release/8.0-rc1

/cc @fanyang-mono

Customer Impact

This PR enables us to collect telemetry data when user enables WasmStripILAfterAOT. There isn't any functional impact to the customer.

Testing

There isn't a good way to test locally. This change uses the same infrastructure as other recently added WorkloadPublishProperties.

Risk

No risk to the customer.

@ghost
Copy link

ghost commented Aug 18, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90820 to release/8.0-rc1

/cc @fanyang-mono

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@fanyang-mono fanyang-mono added the Servicing-consider Issue for next servicing release review label Aug 18, 2023
@SamMonoRT SamMonoRT added this to the 8.0.0 milestone Aug 18, 2023
@SamMonoRT
Copy link
Member

/cc @carlossanlop - if not already late for RC1 backports

@carlossanlop
Copy link
Member

The builds have already started but @mmitche can tell us if we can still take this.

@carlossanlop
Copy link
Member

Approved by Tactics via email.

@carlossanlop carlossanlop added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 19, 2023
@carlossanlop carlossanlop merged commit f8e2a9b into release/8.0-rc1 Aug 19, 2023
23 of 28 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90820-to-release/8.0-rc1 branch August 19, 2023 01:17
@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants