Upgrade our TFM to net9.0 #90880
Upgrade our TFM to net9.0 #90880
Conversation
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsUpgrade the TFM in the repo to net9.0 Drop support for net6.0 and net7.0 Follow-up to #90558
|
src/libraries/Microsoft.Bcl.Cryptography/src/Microsoft.Bcl.Cryptography.csproj
Outdated
Show resolved
Hide resolved
src/libraries/Microsoft.Bcl.TimeProvider/src/Microsoft.Bcl.TimeProvider.csproj
Outdated
Show resolved
Hide resolved
|
@radical can you take a look at the workload changes I made? I'm trying to get the WBT test suites passing. These were/are the last pieces failing in this PR. |
Sure, I can take a look later today. |
| @@ -1,6 +1,6 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk.WebAssembly"> | |||
| <PropertyGroup> | |||
| <TargetFramework>net8.0</TargetFramework> | |||
| <TargetFramework>net9.0</TargetFramework> | |||
There was a problem hiding this comment.
Is there a reason why this project can't use $(NetCoreAppCurrent)?
| <!-- | ||
| The SDK warns if a project targets a framework that doesn't support trimming and IsTrimmable is true. | ||
| We set IsTrimmable higher up in the Directory.Build.props files, so we reset it to false here. | ||
| --> | ||
| <IsTrimmable>false</IsTrimmable> |
There was a problem hiding this comment.
Are you sure this is still necessary? From what I can see, the IsTrimmable=true property is now only set for .NETCoreApp under tools/aot.
I'll have to dig in tomorrow. |
|
re:wasm, we can't change the tfm for wasm.build.tests yet, because these tests build projects with the sdk which needs to start supporting I'm working on this in #91105 , so it doesn't disturb work on this PR. |
Follow-up on dotnet/runtime#90880 These listed TFMs are dotnet/runtime specific and shouldn't be hardcoded in arcade as they change every year. Remove them form the props file and add them back directly in testPackages.proj in dotnet/runtime.
Trying to get this to work for the short period till the sdk moves to
net9.0 would not be worth the effort. Failure:
```
[] Executing (Captured Output) - /root/helix/work/workitem/e/dotnet-latest/dotnet run -c Debug -f net8.0 --no-build - in pwd /root/helix/work/workitem/e/wbt/nonwasm_net8.0_Debug_4utlyi5x_k3s
[] Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=9.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
```
jkoritzinsky
requested review from
marek-safar,
lewing,
pavelsavara and
MichalStrehovsky
as code owners
|
I think we've got everything fixed up here excluding known issues. @ViktorHofer any more feedback? |
|
Yeah, I need to debug one of those new suppressions. They shouldn't show up like that. |
|
Actually, let's look at the baseline suppressions in a follow-up. |
| @@ -5,7 +5,7 @@ | |||
| --> | |||
|
|
|||
| <PropertyGroup> | |||
| <NetCoreAppCurrent>net8.0</NetCoreAppCurrent> | |||
| <NetCoreAppCurrent>net9.0</NetCoreAppCurrent> | |||
There was a problem hiding this comment.
Why not to use NetCoreAppCurrentVersion?
There was a problem hiding this comment.
These projects don't import the repo infrastructure.
ViktorHofer
added
the
needs-breaking-change-doc-created
|
Dropping TFMs is a breaking change. We need to file a breaking change doc before we release .NET 9. |
ghost
locked as resolved and limited conversation to collaborators
ericstj
added
the
breaking-change
Upgrade the TFM in the repo to net9.0
Drop support for net6.0 and net7.0
Follow-up to #90558