Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] [mono] Add telemetry for AndroidStripILAfterAOT #90956

Merged
merged 3 commits into from
Aug 23, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 22, 2023

Backport of #90950 to release/8.0

/cc @fanyang-mono

Customer Impact

This PR enables us to collect telemetry data when user enables AndroidStripILAfterAOT. There isn't any functional impact to the customer.

Testing

There isn't a good way to test locally. This change uses the same infrastructure as other recently added WorkloadPublishProperties.

Risk

No risk to the customer.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 22, 2023
@fanyang-mono fanyang-mono added the Servicing-consider Issue for next servicing release review label Aug 22, 2023
@fanyang-mono fanyang-mono added this to the 8.0.0 milestone Aug 22, 2023
@SamMonoRT
Copy link
Member

@jeffschwMSFT - another release\8.0 PR - adding telemetry for a new opt-in feature for Android.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. we can merge once we have everything ready

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 22, 2023
@carlossanlop
Copy link
Member

CI is green. Since it's approved, I'll merge.

@carlossanlop carlossanlop merged commit 01d66a8 into release/8.0 Aug 23, 2023
22 checks passed
@carlossanlop carlossanlop deleted the backport/pr-90950-to-release/8.0 branch August 23, 2023 19:54
@ghost ghost locked as resolved and limited conversation to collaborators Sep 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants