Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to python generated source #91140

Merged
merged 17 commits into from
Sep 7, 2023
Merged

Conversation

LakshanF
Copy link
Member

@LakshanF LakshanF commented Aug 25, 2023

Switching to genEventing and genEventPipe python scripts to generate provider source files from the universal event list filtered by a file, gen-eventing-event-inc.lst. This list file will make it easy to add new native AOT supported events and the scripts will build the right set of provider source files. The Etw provider source generation script, genEtwProvider, will be checked in later.

@LakshanF LakshanF added this to the 9.0.0 milestone Aug 25, 2023
@LakshanF LakshanF self-assigned this Aug 25, 2023
@ghost
Copy link

ghost commented Aug 25, 2023

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

Issue Details

Switching to genEventing and genEventPipe python scripts. Etw provider switch, genEtwProvider, is not included yet. genEventing script is currently using execute_process instead of add_custom_command to generate the source files.

Author: LakshanF
Assignees: LakshanF
Labels:

area-NativeAOT-coreclr

Milestone: 9.0.0

@LakshanF LakshanF marked this pull request as ready for review August 29, 2023 15:18
src/coreclr/scripts/genEventPipe.py Outdated Show resolved Hide resolved
src/coreclr/scripts/genEventPipe.py Outdated Show resolved Hide resolved
src/coreclr/scripts/genEventing.py Outdated Show resolved Hide resolved
src/coreclr/scripts/genEventing.py Outdated Show resolved Hide resolved
src/coreclr/scripts/genEventing.py Outdated Show resolved Hide resolved
src/coreclr/scripts/genEventing.py Outdated Show resolved Hide resolved
src/coreclr/nativeaot/Runtime/eventpipe/CMakeLists.txt Outdated Show resolved Hide resolved
src/coreclr/nativeaot/Runtime/eventpipe/CMakeLists.txt Outdated Show resolved Hide resolved
src/coreclr/nativeaot/Runtime/eventpipe/CMakeLists.txt Outdated Show resolved Hide resolved
src/coreclr/scripts/genEventPipe.py Outdated Show resolved Hide resolved
src/coreclr/nativeaot/Runtime/eventpipeinternal.cpp Outdated Show resolved Hide resolved
src/coreclr/scripts/genEventing.py Outdated Show resolved Hide resolved
src/coreclr/scripts/genEventing.py Outdated Show resolved Hide resolved
src/coreclr/scripts/genEventing.py Outdated Show resolved Hide resolved
src/coreclr/scripts/genEventing.py Show resolved Hide resolved
src/coreclr/scripts/genEventing.py Outdated Show resolved Hide resolved
src/coreclr/scripts/genEventing.py Outdated Show resolved Hide resolved
@elinor-fung
Copy link
Member

cc @davmason - in case you're interested in the updates to genEventing and genEventPipe python scripts

Copy link
Member

@elinor-fung elinor-fung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

src/coreclr/scripts/genEventing.py Outdated Show resolved Hide resolved
src/coreclr/scripts/genEventing.py Outdated Show resolved Hide resolved
@lateralusX
Copy link
Member

Possible to run a mono build with changed scripts and validate that the generated providers and headers are still the same after this change? I believe we should do similar with CoreCLR as well.

@LakshanF
Copy link
Member Author

LakshanF commented Sep 6, 2023

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LakshanF
Copy link
Member Author

LakshanF commented Sep 6, 2023

Possible to run a mono build with changed scripts and validate that the generated providers and headers are still the same after this change? I believe we should do similar with CoreCLR as well.

Mono will have some changes in the generated header files, clreventpipewriteevents.h and clretwallmain.h, which now with the --inclist arg, will only include the events that are defined in gen-eventing-event-inc.lst.

CoreCLR seems to have generated (prior to this change) mono profiler events and filed #91687 to track that.

@LakshanF LakshanF merged commit 22bf6a6 into dotnet:main Sep 7, 2023
175 checks passed
@LakshanF LakshanF deleted the SwitchToPythonGenSrc branch September 7, 2023 23:13
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants