Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0] Fix diagnostic creation to ensure including the URI #91145

Merged
merged 2 commits into from
Aug 28, 2023
Merged

[release/8.0] Fix diagnostic creation to ensure including the URI #91145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1743bef
Fix diagnostic creation to ensure including the URI
tarekgh Aug 25, 2023
68b3f68
Fix the same issue with the Interop source gen
tarekgh Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Microsoft.Extensions.Logging.Abstractions/gen/DiagnosticDescriptors.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ public static class DiagnosticDescriptors
DiagnosticSeverity.Warning,
isEnabledByDefault: true);

public static DiagnosticDescriptor LoggingUnsupportedLanguageVersion { get; } = new DiagnosticDescriptor(
public static DiagnosticDescriptor LoggingUnsupportedLanguageVersion { get; } = DiagnosticDescriptorHelper.Create(
id: "SYSLIB1026",
title: new LocalizableResourceString(nameof(SR.LoggingUnsupportedLanguageVersionTitle), SR.ResourceManager, typeof(FxResources.Microsoft.Extensions.Logging.Generators.SR)),
messageFormat: new LocalizableResourceString(nameof(SR.LoggingUnsupportedLanguageVersionMessageFormat), SR.ResourceManager, typeof(FxResources.Microsoft.Extensions.Logging.Generators.SR)),
Expand Down
2 changes: 1 addition & 1 deletion ...ibraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/GeneratorDiagnostics.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ public class Ids

/// <inheritdoc cref="SR.HResultTypeWillBeTreatedAsStructMessage"/>
public static readonly DiagnosticDescriptor HResultTypeWillBeTreatedAsStruct =
new DiagnosticDescriptor(
DiagnosticDescriptorHelper.Create(
Ids.NotRecommendedGeneratedComInterfaceUsage,
GetResourceString(nameof(SR.HResultTypeWillBeTreatedAsStructTitle)),
GetResourceString(nameof(SR.HResultTypeWillBeTreatedAsStructMessage)),
Expand Down
Loading