Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] [browser] download sequence optimization #91201

Merged

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Aug 28, 2023

Backport of #90388 to release/8.0

  • when startupMemoryCache false or memory cache is empty, we could fetch DLLs earlier
  • fixed HTML prefetch in samples
  • disabled throttling on perf bench
  • moved checking for memory snapshot to configureRuntimeStartup
  • fixed loading .wasm always
  • calling library initializers and onConfigLoaded for manual config too

Customer Impact

Related
#89631
dotnet/aspnetcore#49909

Testing

Manual and automated tests pass.

Risk

Low: The changes are related to WASM/Blazor startup. It's well covered in automated tests.

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Aug 28, 2023
@pavelsavara pavelsavara added this to the 8.0.0 milestone Aug 28, 2023
@pavelsavara pavelsavara requested a review from maraf August 28, 2023 11:01
@pavelsavara pavelsavara self-assigned this Aug 28, 2023
@ghost
Copy link

ghost commented Aug 28, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #90388 to release/8.0

  • when startupMemoryCache false or memory cache is empty, we could fetch DLLs earlier
  • fixed HTML prefetch in samples
  • disabled throttling on perf bench
  • moved checking for memory snapshot to configureRuntimeStartup
  • fixed loading .wasm always
  • calling library initializers and onConfigLoaded for manual config too

Customer Impact

Related
#89631
dotnet/aspnetcore#49909

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser

Milestone: 8.0.0

@pavelsavara pavelsavara added the Servicing-consider Issue for next servicing release review label Aug 28, 2023
@maraf maraf requested a review from marek-safar August 28, 2023 11:12
@pavelsavara pavelsavara marked this pull request as ready for review August 28, 2023 12:13
@carlossanlop
Copy link
Member

@pavelsavara this needs M2 approval. @lewing / @marek-safar do you approve?

@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 29, 2023
@carlossanlop carlossanlop merged commit dddf0d0 into dotnet:release/8.0 Aug 29, 2023
36 of 37 checks passed
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 29, 2023
@pavelsavara pavelsavara deleted the backport/pr-90388-to-release/8.0 branch September 2, 2024 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants