-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Emit interceptor info correctly when invocation expr is on separate line #91218
Conversation
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsBackport of #91107 to release/8.0 /cc @layomia Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
...s.Options.ConfigurationExtensions/tests/Common/OptionsBuilderConfigurationExtensionsTests.cs
Show resolved
Hide resolved
@layomia this needs M2 approval. @ericstj or @jeffhandley do you approve? |
...s.Options.ConfigurationExtensions/tests/Common/OptionsBuilderConfigurationExtensionsTests.cs
Show resolved
Hide resolved
* Add comments to binding gen tests for invocations on new lines * Address feedback & test static method call syntax * Reorganize and comment the newline/whitespace scenarios * Reorganize and comment the newline/whitespace scenarios for ConfigurationExtensions --------- Co-authored-by: Jeff Handley <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has my support for RC2. It fixes a bug in a new net8 feature, and we would service for this.
@carlossanlop pls help merge. |
Backport of #91107 to release/8.0
/cc @layomia
Customer Impact
Fixes the following issue which users will definitely run into & expect to work.
Same line
Interceptor location is successfully parsed. Project compiles:
Different line
Parsed interceptor location is inaccurate. Compilation fails with a CSC interceptors error stating that the generated
[InterceptsLocation]
points to an invalid location.Testing
Automated unit tests verify the fix for a wide range of permitted language syntax. Manually verified in showcase ASP.NET app.
Risk
Low. It's a small, contained fix for an off-by-default component.