Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DebuggerDisplay to ListDictionaryInternal #91224

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

arturek
Copy link
Contributor

@arturek arturek commented Aug 28, 2023

The Exception class uses ListDictionaryInternal for its Data property and usually leaves it empty. With the DebuggerDisplay attribute, it should be easier to see instances when this collection is not empty and save time spent unnecessarily expanding it.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Aug 28, 2023
@ghost
Copy link

ghost commented Aug 28, 2023

Tagging subscribers to this area: @dotnet/area-system-collections
See info in area-owners.md if you want to be subscribed.

Issue Details

The Exception class uses ListDictionaryInternal for its Data property and usually leaves it empty. With the DebuggerDisplay attribute, it should be easier to see instances when this collection is not empty and save time spent unnecessarily expanding it.

Author: arturek
Assignees: -
Labels:

area-System.Collections

Milestone: -

@tarekgh tarekgh added this to the 9.0.0 milestone Aug 28, 2023
@tarekgh tarekgh merged commit 00838f3 into dotnet:main Aug 28, 2023
168 of 170 checks passed
@arturek arturek deleted the DebuggerDisplay-ListDictionaryInternal branch August 29, 2023 06:31
@ghost ghost locked as resolved and limited conversation to collaborators Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Collections community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants