[release/8.0] Fix crash when calling AssemblyLoadContext.Unload twice #91346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The AssemblyLoadContext.InitiateUnload method was not handling multiple calls correctly. Instead of making the extra calls dummy, it was calling the native runtime helper again. This change fixes it by simply ensuring that the runtime helper is called just once.
janvorli
added
Servicing-consider
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsBackport of #91283 to release/8.0 /cc @janvorli Customer ImpactWhen a customer code calls the TestingDirected test for the issue, libraries tests, coreclr tests, CI testing RiskLow, the change just ensures that the call to the underlying native runtime helper method is made only once.
|
|
@jkotas can you please give a code review sign-off? |
jeffschwMSFT
approved these changes
Aug 30, 2023
jeffschwMSFT
added
Servicing-approved
jkotas
approved these changes
Aug 30, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91283 to release/8.0
/cc @janvorli
Customer Impact
When a customer code calls the
AssemblyLoadContext.Unloadmethod twice, runtime crashes with a FailFast. Only the first call to theUnloadmethod should have any effect, further calls to it should be a no-op.Testing
Directed test for the issue, libraries tests, coreclr tests, CI testing
Risk
Low, the change just ensures that the call to the underlying native runtime helper method is made only once.