Fix nullable annotation for Validator.ValidateValue ref source #91351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarekgh
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Sorry I missed that in my original review. Thanks to @stephentoub for catching it!
|
@jeffhandley should we mark it with 8.0 milestone instead? just to indicate this change went to 8.0 too. |
|
Tagging subscribers to this area: @dotnet/area-system-componentmodel-dataannotations Issue DetailsContributes to #91162. This ref source change was missed in #91286 and caught during the release/8.0 backport review in #91293 (comment).
|
This comment was marked as resolved.
This comment was marked as resolved.
Another +1 for enlightening our api compat tools about nullable reference types |
jeffhandley
added a commit
that referenced
this pull request
Aug 30, 2023
carlossanlop
pushed a commit
that referenced
this pull request
Aug 31, 2023
…and ValidateValue (#91293) * Fix nullable annotation for Validator.TryValidateValue and ValidateValue * Revert Options source generator nullable annotation changes for Validator.TryValidateValue (#91305) * Fix nullable annotation for Validator.ValidateValue ref source (#91351) --------- Co-authored-by: Jeff Handley <[email protected]>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #91162. This ref source change was missed in #91286 and caught during the release/8.0 backport review in #91293 (comment).