Options Source Gen Fixes #91363
Merged
Options Source Gen Fixes #91363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-extensions-options Issue DetailsPlanning to port these fixes to rc2 The changes in this PR fix the following issues:
|
tarekgh
added
the
source-generator
stephentoub
reviewed
Aug 31, 2023
stephentoub
reviewed
Aug 31, 2023
stephentoub
reviewed
Aug 31, 2023
Comment on lines
+449
to
+461
| /// <summary> | ||
| /// Returns a non-randomized hash code for the given string. | ||
| /// We always return a positive value. | ||
| /// </summary> | ||
| internal static int GetNonRandomizedHashCode(string s) | ||
| { | ||
| uint result = 2166136261u; | ||
| foreach (char c in s) | ||
| { | ||
| result = (c ^ result) * 16777619; | ||
| } | ||
| return Math.Abs((int)result); | ||
| } |
There was a problem hiding this comment.
We might want to consider using SHA256 here instead of FNV-1a. I think that's what the compiler itself uses when it needs uniqueness.
There was a problem hiding this comment.
After offline discussion, we decided to stick with FNV-1a.
|
Failing tests tracked by #91410 |
jeffhandley
approved these changes
Aug 31, 2023
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/6043270790 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Planning to port these fixes to rc2
The changes in this PR fix the following issues:
Randomin the source generator and instead use the module name hash. Options source generator shouldn't use random names #90990!when callingValidator.TryValidateValueIEnumerable<T>and tagged with the attributeValidateEnumeratedItems