Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix official builds for NativeAOT #91454

Merged
merged 2 commits into from
Sep 1, 2023
Merged

Fix official builds for NativeAOT #91454

merged 2 commits into from
Sep 1, 2023

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Sep 1, 2023

Fixes regression introduced in #91233

The ILLink ProjectReference output shouldn't be copied to consuming projects.

From the docs:

Private Optional boolean. Specifies whether the reference should be copied to the output folder. This attribute matches the Copy Local property of the reference that's in the Visual Studio IDE.

From what I can see, this is only happening on NativeAOT legs because of this glob:

<ItemGroup Condition="'$(BuildNativeAOTRuntimePack)' == 'true'">
<_nativeAotRuntimeFiles Include="$(CoreCLRAotSdkDir)*" />
<RuntimeFiles Include="@(_nativeAotRuntimeFiles)" Condition="'%(Extension)' != '.xml'">
<IsNative>true</IsNative>
</RuntimeFiles>
</ItemGroup>

The ILLink ProjectReference output shouldn't be copied to consuming projects.

From the docs:
> Private	Optional boolean. Specifies whether the reference should be copied to the output folder. This attribute matches the Copy Local property of the reference that's in the Visual Studio IDE.
@ViktorHofer ViktorHofer self-assigned this Sep 1, 2023
@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label Sep 1, 2023
@ViktorHofer ViktorHofer added area-Infrastructure and removed area-Infrastructure-libraries linkable-framework Issues associated with delivering a linker friendly framework labels Sep 1, 2023
@ghost ghost added the linkable-framework Issues associated with delivering a linker friendly framework label Sep 1, 2023
@ghost
Copy link

ghost commented Sep 1, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes regression introduced in #91233

The ILLink ProjectReference output shouldn't be copied to consuming projects.

From the docs:

Private Optional boolean. Specifies whether the reference should be copied to the output folder. This attribute matches the Copy Local property of the reference that's in the Visual Studio IDE.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure-libraries, linkable-framework

Milestone: -

@ghost
Copy link

ghost commented Sep 1, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes regression introduced in #91233

The ILLink ProjectReference output shouldn't be copied to consuming projects.

From the docs:

Private Optional boolean. Specifies whether the reference should be copied to the output folder. This attribute matches the Copy Local property of the reference that's in the Visual Studio IDE.

Author: ViktorHofer
Assignees: ViktorHofer
Labels:

area-Infrastructure

Milestone: -

eng/illink.targets Outdated Show resolved Hide resolved
Co-authored-by: Alexander Köplinger <[email protected]>
@ViktorHofer ViktorHofer merged commit f470200 into main Sep 1, 2023
157 of 172 checks passed
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-2 branch September 1, 2023 09:23
@sbomer
Copy link
Member

sbomer commented Sep 1, 2023

Thanks for the fix!

@agocke
Copy link
Member

agocke commented Sep 1, 2023

Thanks! I have to say, "Private=false" meaining "don't copy" makes absolutely no sense to me, but at least it works!

@ViktorHofer
Copy link
Member Author

At least it's documented ;)

@ghost ghost locked as resolved and limited conversation to collaborators Oct 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Infrastructure linkable-framework Issues associated with delivering a linker friendly framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants