-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix official builds for NativeAOT #91454
Conversation
The ILLink ProjectReference output shouldn't be copied to consuming projects. From the docs: > Private Optional boolean. Specifies whether the reference should be copied to the output folder. This attribute matches the Copy Local property of the reference that's in the Visual Studio IDE.
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsFixes regression introduced in #91233 The ILLink ProjectReference output shouldn't be copied to consuming projects. From the docs:
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsFixes regression introduced in #91233 The ILLink ProjectReference output shouldn't be copied to consuming projects. From the docs:
|
Co-authored-by: Alexander Köplinger <[email protected]>
Thanks for the fix! |
Thanks! I have to say, "Private=false" meaining "don't copy" makes absolutely no sense to me, but at least it works! |
At least it's documented ;) |
Fixes regression introduced in #91233
The ILLink ProjectReference output shouldn't be copied to consuming projects.
From the docs:
From what I can see, this is only happening on NativeAOT legs because of this glob:
runtime/eng/liveBuilds.targets
Lines 82 to 87 in 91ac6b3