[release/8.0] [browser] ENVIRONMENT_IS_WEB is also true on WebWorker #91627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
lewing,
pavelsavara and
kg
as code owners
dotnet-issue-labeler
bot
added
the
needs-area-label
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsBackport of #91589 to release/8.0 /cc @pavelsavara Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
kg
approved these changes
Sep 5, 2023
lewing
removed
the
needs-area-label
|
@marek-safar @lewing can we get your seal of approval here? |
marek-safar
approved these changes
Sep 15, 2023
carlossanlop
added
Servicing-approved
Closed
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91589 to release/8.0
/cc @pavelsavara
Customer Impact
Fixes customer reported issue #91528
When dotnet is started from web worker, it will exit after first async Task/Promise or GC.
Testing
Manual testing and CI
Risk
Corner case use-case fixed.
It may impact multi-threading build which is not supported on Net8 yet.
It should have no impact for Blazor.