[release/8.0] Add Microsoft.Extensions.Options.SourceGeneration to Transport Package #91700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsBackport of #91685 to release/8.0 /cc @tarekgh Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
@ericstj could you please approve it? Thanks! |
ericstj
added
Servicing-approved
|
Approved as this is necessary to ship the product, and #91698 tracks avoiding such issues on the future. |
ericstj
approved these changes
Sep 6, 2023
This was referenced Sep 7, 2023
ViktorHofer
approved these changes
Sep 7, 2023
|
@ViktorHofer the CI failures are known and tracked issues. Could you please merge this PR? Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91685 to release/8.0
/cc @tarekgh
Customer Impact
This change is important to allow adding the Options Validation source gen to the aspnet.
Testing
regression tests
Risk
low, no real product change more than including the options source gen to the transport package.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.