[release/8.0] Make Options source gen support Validation attributes having constructor with array parameters #91934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…tor with params Parameter
|
Tagging subscribers to this area: @dotnet/area-extensions-options Issue DetailsBackport of #91915 to release/8.0 /cc @tarekgh Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
|
@ericstj could you please have a look and approve it if you have no concern with the change? Thanks! |
ericstj
changed the title
ericstj
changed the title
ericstj
reviewed
Sep 12, 2023
tarekgh
reviewed
Sep 12, 2023
src/libraries/Microsoft.Extensions.Options/tests/SourceGeneration.Unit.Tests/Main.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Sep 12, 2023
src/libraries/Microsoft.Extensions.Options/tests/SourceGeneration.Unit.Tests/Main.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Sep 12, 2023
src/libraries/Microsoft.Extensions.Options/tests/SourceGeneration.Unit.Tests/Main.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Sep 12, 2023
src/libraries/Microsoft.Extensions.Options/tests/SourceGeneration.Unit.Tests/Main.cs
Outdated
Show resolved
Hide resolved
tarekgh
reviewed
Sep 12, 2023
src/libraries/Microsoft.Extensions.Options/tests/SourceGenerationTests/EmitterTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Eric StJohn <[email protected]>
jeffhandley
approved these changes
Sep 13, 2023
|
Otherwise, M2 Approved. |
artl93
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #91915 to release/8.0
/cc @tarekgh
Customer Impact
.NET 8.0 introduces the Options Validation Source Generator, the change here addressing a specific scenario involving validation attribute constructors that utilize arrays, including those using the
paramskeyword. The cloud native team encountered an issue where the source generator would throw an exception, resulting in the failure to generate any code and disrupting the build process. This fix is crucial to ensure the successful completion of the feature and remove obstacles for source generator users.Testing
It passed all regression tests and I have added more tests to cover the new cases we are fixing.
Risk
Low because we didn't change any handling in the already supported cases. The change here is an addition to cover the new case.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.