Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Update Marshal.QueryInterface() argument modifier #91984

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 13, 2023

Backport of #91983 to release/8.0

/cc @AaronRobinsonMSFT

Customer Impact

This change is introducing new warnings that can impact users. See #91981.

Testing

Validate no warnings are emitted for ref readonly when used with either in or ref.

Risk

None.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Change "in" modifier to "ref readonly" to avoid warnings
in existing interop code.
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Sep 13, 2023

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #91983 to release/8.0

/cc @AaronRobinsonMSFT

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Runtime.InteropServices, new-api-needs-documentation

Milestone: -

@AaronRobinsonMSFT AaronRobinsonMSFT added the Servicing-consider Issue for next servicing release review label Sep 13, 2023
@AaronRobinsonMSFT AaronRobinsonMSFT modified the milestones: 9.0.0, 8.0.0 Sep 13, 2023
@AaronRobinsonMSFT
Copy link
Member

/cc @tannergooding @stephentoub @jkotas

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved. please get a code review. once ready it can be merged

@AaronRobinsonMSFT
Copy link
Member

@tannergooding or @stephentoub, Can I get a review here?

@carlossanlop carlossanlop merged commit 8ed11a2 into release/8.0 Sep 14, 2023
181 checks passed
@carlossanlop carlossanlop deleted the backport/pr-91983-to-release/8.0 branch September 14, 2023 00:11
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants