Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][Android] Refactor invoking native handler in HttpClientHandler #92051

Conversation

simonrozsival
Copy link
Member

This is a follow-up to #91520 to address @marek-safar's comments.

I explored the idea of using [CallerLineNumber] as the caching key. To make it harder to cause collisions, I wrapped the invoking method in a file scoped static class. I'm still not sure it's a good idea so I'm keeping this PR as a draft for now.

In the long term, we should be able to replace all of this logic with [UnsafeAccessor] methods once the new API proposal for [UnsafeAccessorType] is approved and implemented.

@ghost
Copy link

ghost commented Sep 14, 2023

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a follow-up to #91520 to address @marek-safar's comments.

I explored the idea of using [CallerLineNumber] as the caching key. To make it harder to cause collisions, I wrapped the invoking method in a file scoped static class. I'm still not sure it's a good idea so I'm keeping this PR as a draft for now.

In the long term, we should be able to replace all of this logic with [UnsafeAccessor] methods once the new API proposal for [UnsafeAccessorType] is approved and implemented.

Author: simonrozsival
Assignees: simonrozsival
Labels:

area-System.Net.Http

Milestone: -

@ghost
Copy link

ghost commented Sep 14, 2023

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

This is a follow-up to #91520 to address @marek-safar's comments.

I explored the idea of using [CallerLineNumber] as the caching key. To make it harder to cause collisions, I wrapped the invoking method in a file scoped static class. I'm still not sure it's a good idea so I'm keeping this PR as a draft for now.

In the long term, we should be able to replace all of this logic with [UnsafeAccessor] methods once the new API proposal for [UnsafeAccessorType] is approved and implemented.

Author: simonrozsival
Assignees: simonrozsival
Labels:

area-System.Net.Http, os-android, os-ios

Milestone: -

@karelz karelz added this to the 9.0.0 milestone Oct 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants