Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Fix URL for syslib diagnostics #92160

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 15, 2023

Backport of #92134 to release/8.0

/cc @ericstj

Customer Impact

Source generators using syslib diagnostics have a broken URL. We had included the .md extensions on the URLs which is not required.

Testing

Build / test of new links to ensure they're working correctly. Review of other help URL formats to ensure no other instances of same bug.

Risk

Very-low.

@ghost
Copy link

ghost commented Sep 15, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92134 to release/8.0

/cc @ericstj

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@ericstj ericstj added the Servicing-consider Issue for next servicing release review label Sep 15, 2023
Copy link
Member

@artl93 artl93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 approved.

@artl93 artl93 added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 15, 2023
@ericstj ericstj merged commit 7b32406 into release/8.0 Sep 16, 2023
105 of 111 checks passed
@jkotas jkotas deleted the backport/pr-92134-to-release/8.0 branch September 16, 2023 13:18
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants