Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] [browser] Add link to docs to interop error messages #92182

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 16, 2023

Backport of #92125 to release/8.0

/cc @maraf

Customer Impact

User that run into an unsupported scenario in JS interop get an error message containing a link to docs

Example

error SYSLIB1072: The type 'Task<int[]>' is not supported by source-generated JavaScript interop. The generated source will not handle marshalling of parameter 'meaning'. For more information see https://aka.ms/dotnet-wasm-jsinterop

Testing

Manual + unit tests

Risk

None

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Sep 16, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #92125 to release/8.0

/cc @maraf

Customer Impact

User that run into an unsupported scenario in JS interop get an error message containing a link to docs

Example

error SYSLIB1072: The type 'Task<int[]>' is not supported by source-generated JavaScript interop. The generated source will not handle marshalling of parameter 'meaning'. For more information see https://aka.ms/dotnet-wasm-jsinterop

Testing

Manual + unit tests

Risk

None

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser

Milestone: -

@maraf maraf added this to the 8.0.0 milestone Sep 16, 2023
@maraf maraf added the Servicing-consider Issue for next servicing release review label Sep 16, 2023
@carlossanlop
Copy link
Member

@pavelsavara can you please also sign-off this backport?

@lewing @marek-safar do we have your approval to merge this?

@marek-safar marek-safar added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 17, 2023
@carlossanlop carlossanlop merged commit 6c9a743 into release/8.0 Sep 18, 2023
118 of 123 checks passed
@carlossanlop carlossanlop deleted the backport/pr-92125-to-release/8.0 branch September 18, 2023 17:22
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants