-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Fix: Config binder generator doesn't generate code when named arguments are out of order #92257
Conversation
…, add test for OptionsBuilder... and ServiceCollection extensins
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsBackport of #91961 to release/8.0 /cc @buyaa-n Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of this. Fixes a compile-blocking issue in Config Binder source gen. Changes are minimal and well tested. @artl93 please give this your ACK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
M2 approved.
The |
Backport of #91961 to release/8.0
/cc @buyaa-n
Customer Impact
When user uses named arguments for the binding calls and if they are out of order the source generator silently bails out without generating the source. The user code fall through the reflection path. This is a broken edge case scenario of new 8.0 feature.
Testing
Corresponding unit tests added
Risk
Very low: The fix is easy and straightforward, the generator is off by default, thoroughly tested with new unit tests