Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Fix: Config binder generator doesn't generate code when named arguments are out of order #92257

Merged
merged 6 commits into from
Sep 19, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 19, 2023

Backport of #91961 to release/8.0

/cc @buyaa-n

Customer Impact

When user uses named arguments for the binding calls and if they are out of order the source generator silently bails out without generating the source. The user code fall through the reflection path. This is a broken edge case scenario of new 8.0 feature.

Testing

Corresponding unit tests added

Risk

Very low: The fix is easy and straightforward, the generator is off by default, thoroughly tested with new unit tests

@ghost
Copy link

ghost commented Sep 19, 2023

Tagging subscribers to this area: @dotnet/area-extensions-configuration
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #91961 to release/8.0

/cc @buyaa-n

Customer Impact

Testing

Risk

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

  • If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-Extensions-Configuration

Milestone: -

@buyaa-n buyaa-n added this to the 8.0.0 milestone Sep 19, 2023
@buyaa-n buyaa-n added the Servicing-consider Issue for next servicing release review label Sep 19, 2023
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this. Fixes a compile-blocking issue in Config Binder source gen. Changes are minimal and well tested. @artl93 please give this your ACK.

Copy link
Contributor

@artl93 artl93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M2 approved.

@artl93 artl93 added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 19, 2023
@carlossanlop
Copy link
Member

The runtime osx-arm64 Release NativeAOT_Libraries leg has been getting stuck in all PRs in release/8.0, so I'm going to have to ignore it.

@carlossanlop carlossanlop merged commit a4459b5 into release/8.0 Sep 19, 2023
105 of 111 checks passed
@carlossanlop carlossanlop deleted the backport/pr-91961-to-release/8.0 branch September 19, 2023 04:38
@radical radical mentioned this pull request Sep 26, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants